Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1769)

Unified Diff: chrome/browser/android/webapk/webapk_update_manager.h

Issue 2409453002: Fix crash on WebAPK startup (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/webapk/webapk_update_manager.h
diff --git a/chrome/browser/android/webapk/webapk_update_manager.h b/chrome/browser/android/webapk/webapk_update_manager.h
index 11ae9033d972da369ffda3cab7ce5e98b9baa6d0..9201c142fee1438a79bb62227882cf4b83d69d7e 100644
--- a/chrome/browser/android/webapk/webapk_update_manager.h
+++ b/chrome/browser/android/webapk/webapk_update_manager.h
@@ -21,7 +21,9 @@ class WebApkUpdateManager {
// |success| indicates whether the request was issued to the server. A "true"
dominickn 2016/10/10 06:05:38 Minor nit: reflow this comment.
pkotwicz 2016/10/10 16:42:01 What do you mean? Are you suggesting that there sh
dominickn 2016/10/11 04:54:05 Yes, that's what I meant. Pretty minor, feel free
// value of |success| does not guarantee that the WebAPK will be successfully
// updated.
- static void OnBuiltWebApk(bool success, const std::string& webapk_package);
+ static void OnBuiltWebApk(const std::string& id,
+ bool success,
+ const std::string& webapk_package);
private:
DISALLOW_IMPLICIT_CONSTRUCTORS(WebApkUpdateManager);

Powered by Google App Engine
This is Rietveld 408576698