Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2451)

Unified Diff: chrome/browser/android/webapk/webapk_installer.cc

Issue 2409453002: Fix crash on WebAPK startup (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/webapk/webapk_installer.cc
diff --git a/chrome/browser/android/webapk/webapk_installer.cc b/chrome/browser/android/webapk/webapk_installer.cc
index 403297873b469a9e96ed2854038716e31e891f71..118e10e5038027597f56cc22025b57bd767d3ba4 100644
--- a/chrome/browser/android/webapk/webapk_installer.cc
+++ b/chrome/browser/android/webapk/webapk_installer.cc
@@ -493,6 +493,7 @@ void WebApkInstaller::OnSuccess() {
void WebApkInstaller::OnFailure() {
FinishCallback callback = finish_callback_;
dominickn 2016/10/10 06:05:38 Any particular reason this needs to be deleted bef
pkotwicz 2016/10/10 16:42:01 There is no particular reason. Changed as requeste
+ std::string webapk_package = webapk_package_;
delete this;
- callback.Run(false, "");
+ callback.Run(false, webapk_package);
}

Powered by Google App Engine
This is Rietveld 408576698