Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3044)

Unified Diff: chrome/browser/safe_browsing/srt_fetcher_win.cc

Issue 2409443002: Make GlobalErrorService's ownership model slightly less insane. (Closed)
Patch Set: windows, ownership Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/safe_browsing/srt_fetcher_win.cc
diff --git a/chrome/browser/safe_browsing/srt_fetcher_win.cc b/chrome/browser/safe_browsing/srt_fetcher_win.cc
index a242a1ad2b23bfdcab28bf42c2433164a5710a70..b00f64a8ab0d66e74dae9f05ab9756332c7c0efb 100644
--- a/chrome/browser/safe_browsing/srt_fetcher_win.cc
+++ b/chrome/browser/safe_browsing/srt_fetcher_win.cc
@@ -18,6 +18,7 @@
#include "base/debug/leak_annotations.h"
#include "base/files/file_path.h"
#include "base/macros.h"
+#include "base/memory/ptr_util.h"
#include "base/metrics/field_trial.h"
#include "base/metrics/histogram_macros.h"
#include "base/metrics/sparse_histogram.h"
@@ -527,7 +528,7 @@ void DisplaySRTPrompt(const base::FilePath& download_path) {
// Ownership of |global_error| is passed to the service. The error removes
// itself from the service and self-destructs when done.
- global_error_service->AddGlobalError(global_error);
+ global_error_service->AddOwnedGlobalError(base::WrapUnique(global_error));
bool show_bubble = true;
PrefService* local_state = g_browser_process->local_state();

Powered by Google App Engine
This is Rietveld 408576698