Make GlobalErrorService's ownership model slightly less insane.

chrome/browser/extensions/extension_disabled_ui.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/extension_disabled_ui.h"
 
 #include <bitset>
 #include <memory>
 #include <string>
 #include <utility>
@@ skipping 413 matching lines @@
 }
 
 void ExtensionDisabledGlobalError::OnShutdown(
     extensions::ExtensionRegistry* registry) {
   DCHECK_EQ(extensions::ExtensionRegistry::Get(service_->profile()), registry);
   registry_observer_.RemoveAll();
 }
 
 void ExtensionDisabledGlobalError::RemoveGlobalError() {
   GlobalErrorServiceFactory::GetForProfile(service_->profile())
-      ->RemoveGlobalError(this);
+      ->RemoveOwnedGlobalError(this).release();

[Nico, 2016/10/10 14:03:37]

Hm, I think this'd be nicer if it stored the result in a local and then called
release right next to the call to DeleteSoon().

DeleteSoon() should probably have a version taking a unique_ptr, then the return
value could be moved to DeleteSoon().

[Avi (use Gerrit), 2016/10/10 16:52:36]

Done.

   registrar_.RemoveAll();
   registry_observer_.RemoveAll();
   // Delete this object after any running tasks, so that the extension dialog
   // still has it as a delegate to finish the current tasks.
   base::ThreadTaskRunnerHandle::Get()->DeleteSoon(FROM_HERE, this);
 }
 
 // Globals --------------------------------------------------------------------
 
 namespace extensions {
 
 void AddExtensionDisabledErrorWithIcon(base::WeakPtr<ExtensionService> service,
                                        const std::string& extension_id,
                                        bool is_remote_install,
                                        const gfx::Image& icon) {
   if (!service.get())
     return;
   const Extension* extension = service->GetInstalledExtension(extension_id);
   if (extension) {
     GlobalErrorServiceFactory::GetForProfile(service->profile())
-        ->AddGlobalError(new ExtensionDisabledGlobalError(
+        ->AddOwnedGlobalError(base::MakeUnique<ExtensionDisabledGlobalError>(
             service.get(), extension, is_remote_install, icon));
   }
 }
 
 void AddExtensionDisabledError(ExtensionService* service,
                                const Extension* extension,
                                bool is_remote_install) {
   extensions::ExtensionResource image = extensions::IconsInfo::GetIconResource(
       extension, kIconSize, ExtensionIconSet::MATCH_BIGGER);
   gfx::Size size(kIconSize, kIconSize);
@@ skipping 11 matching lines @@
                                  content::WebContents* web_contents,
                                  const Extension* extension) {
   std::unique_ptr<ExtensionInstallPrompt> install_ui(
       new ExtensionInstallPrompt(web_contents));
   // This object manages its own lifetime.
   new ExtensionDisabledDialogDelegate(service, std::move(install_ui),
                                       extension);
 }
 
 }  // namespace extensions