Make GlobalErrorService's ownership model slightly less insane.

chrome/browser/safe_browsing/srt_global_error_win.cc

Index: chrome/browser/safe_browsing/srt_global_error_win.cc
diff --git a/chrome/browser/safe_browsing/srt_global_error_win.cc b/chrome/browser/safe_browsing/srt_global_error_win.cc
index a5f6b2df989c215f0a5e756b5301ceebec653a84..5172781e036f46ea58d6da16706e6fc54272944c 100644
--- a/chrome/browser/safe_browsing/srt_global_error_win.cc
+++ b/chrome/browser/safe_browsing/srt_global_error_win.cc
@@ -221,8 +221,8 @@ void SRTGlobalError::MaybeExecuteSRT() {
     return;
   }
   // At this point, this object owns itself, since ownership has been taken back
-  // from the global_error_service_ in the call to RemoveGlobalError. This means
-  // that it is safe to use base::Unretained here.
+  // from the global_error_service_ in the call to OnUserInteractionStarted.
+  // This means that it is safe to use base::Unretained here.
   BrowserThread::PostBlockingPoolTask(
       FROM_HERE,
       base::Bind(
@@ -262,7 +262,7 @@ void SRTGlobalError::OnUserinteractionStarted(
   RecordSRTPromptHistogram(histogram_value);
   interacted_ = true;
   if (global_error_service_) {
-    global_error_service_->RemoveGlobalError(this);
+    global_error_service_->RemoveGlobalError(this).release();
     global_error_service_ = nullptr;

[Nico, 2016/12/13 15:54:14]

isn't `this` dead after the release() call in the previous line?

[Avi (use Gerrit), 2016/12/13 16:06:00]

No; this is a release(), not a reset(). It's taking ownership back from the
global error service.

   }
 }