Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(365)

Unified Diff: chrome/browser/sync/sync_global_error.cc

Issue 2409443002: Make GlobalErrorService's ownership model slightly less insane. (Closed)
Patch Set: deprecation notice Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/sync/sync_global_error.cc
diff --git a/chrome/browser/sync/sync_global_error.cc b/chrome/browser/sync/sync_global_error.cc
index 476a9796af4c57cbf66f2976065226c982061ea5..faf79e44e3e7ecb7b85203de838ea9dc70ccf4a6 100644
--- a/chrome/browser/sync/sync_global_error.cc
+++ b/chrome/browser/sync/sync_global_error.cc
@@ -30,7 +30,7 @@ SyncGlobalError::SyncGlobalError(
DCHECK(sync_service_);
error_controller_->AddObserver(this);
if (!switches::IsMaterialDesignUserMenu())
- global_error_service_->AddGlobalError(this);
+ global_error_service_->AddUnownedGlobalError(this);
}
SyncGlobalError::~SyncGlobalError() {
@@ -40,7 +40,7 @@ SyncGlobalError::~SyncGlobalError() {
void SyncGlobalError::Shutdown() {
if (!switches::IsMaterialDesignUserMenu())
- global_error_service_->RemoveGlobalError(this);
+ global_error_service_->RemoveUnownedGlobalError(this);
error_controller_->RemoveObserver(this);
error_controller_ = nullptr;
}

Powered by Google App Engine
This is Rietveld 408576698