Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1680)

Unified Diff: chrome/browser/android/data_usage/data_use_ui_tab_model.cc

Issue 2409423005: Compare GURLs to kUrlConstants with .spec() and string equality (Closed)
Patch Set: rebase on dependent patch Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/app_controller_mac.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/android/data_usage/data_use_ui_tab_model.cc
diff --git a/chrome/browser/android/data_usage/data_use_ui_tab_model.cc b/chrome/browser/android/data_usage/data_use_ui_tab_model.cc
index 859069394ae21d9a851bb045c4eb01c0230818fe..8db9e0e5e78dec9ac28a58e260d1c6ac921fc060 100644
--- a/chrome/browser/android/data_usage/data_use_ui_tab_model.cc
+++ b/chrome/browser/android/data_usage/data_use_ui_tab_model.cc
@@ -275,8 +275,7 @@ bool DataUseUITabModel::ConvertTransitionType(
*transition_type = DataUseTabModel::TRANSITION_BOOKMARK;
return true;
case ui::PAGE_TRANSITION_AUTO_TOPLEVEL:
- if (gurl == GURL(kChromeUIHistoryFrameURL) ||
- gurl == GURL(kChromeUIHistoryURL)) {
+ if (gurl == kChromeUIHistoryFrameURL || gurl == kChromeUIHistoryURL) {
// History menu.
*transition_type = DataUseTabModel::TRANSITION_HISTORY_ITEM;
return true;
« no previous file with comments | « no previous file | chrome/browser/app_controller_mac.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698