chrome/browser/app_controller_mac.mm - Issue 2409423005: Compare GURLs to kUrlConstants with .spec() and string equality

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/app_controller_mac.mm

Issue 2409423005: Compare GURLs to kUrlConstants with .spec() and string equality (Closed)

Patch Set: rebase on dependent patch Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/app_controller_mac.mm

diff --git a/chrome/browser/app_controller_mac.mm b/chrome/browser/app_controller_mac.mm

index 01449b0b36bf24fb4ea45424fdd236554c9acbb2..a0a29dda97cf02aaa6fbc3e722cc035ab900e4fe 100644

--- a/chrome/browser/app_controller_mac.mm

+++ b/chrome/browser/app_controller_mac.mm

@@ -703,7 +703,7 @@ class AppControllerProfileObserver : public ProfileAttributesStorage::Observer {

[self openUrls:urls];

if (startupIndex != TabStripModel::kNoTab &&

- startupContent->GetVisibleURL() == GURL(chrome::kChromeUINewTabURL)) {

+ startupContent->GetVisibleURL() == chrome::kChromeUINewTabURL) {

browser->tab_strip_model()->CloseWebContentsAt(startupIndex,

TabStripModel::CLOSE_NONE);

}