chrome/browser/sessions/session_restore.cc - Issue 2409423005: Compare GURLs to kUrlConstants with .spec() and string equality

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sessions/session_restore.cc

Issue 2409423005: Compare GURLs to kUrlConstants with .spec() and string equality (Closed)

Patch Set: git cl format Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/sessions/session_restore.cc

diff --git a/chrome/browser/sessions/session_restore.cc b/chrome/browser/sessions/session_restore.cc

index 4620241d6de114bb3232cda59b0187a67034d3f3..f1fae0257e72bb8772cb52fdeac3ead0fbb4a6f1 100644

--- a/chrome/browser/sessions/session_restore.cc

+++ b/chrome/browser/sessions/session_restore.cc

@@ -773,7 +773,7 @@ void SessionRestore::RestoreSessionAfterCrash(Browser* browser) {

if (browser->tab_strip_model()->count() == 1) {

const content::WebContents* active_tab =

browser->tab_strip_model()->GetWebContentsAt(0);

- if (active_tab->GetURL() == GURL(chrome::kChromeUINewTabURL) ||

+ if (active_tab->GetURL().spec() == chrome::kChromeUINewTabURL ||

search::IsInstantNTP(active_tab)) {

// There is only one tab and its the new tab page, make session restore

// clobber it.