Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Unified Diff: chrome/browser/sync/chrome_sync_client.cc

Issue 2409423005: Compare GURLs to kUrlConstants with .spec() and string equality (Closed)
Patch Set: git cl format Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/sync/chrome_sync_client.cc
diff --git a/chrome/browser/sync/chrome_sync_client.cc b/chrome/browser/sync/chrome_sync_client.cc
index a549fbb4c3484a63e1a4731418289a2a7dfc8ea4..5f0fa8172e97129d1ac63aac0a66ef5ffc3d5524 100644
--- a/chrome/browser/sync/chrome_sync_client.cc
+++ b/chrome/browser/sync/chrome_sync_client.cc
@@ -151,7 +151,7 @@ class SyncSessionsClientImpl : public sync_sessions::SyncSessionsClient {
profile_, ServiceAccessType::EXPLICIT_ACCESS);
}
bool ShouldSyncURL(const GURL& url) const override {
- if (url == GURL(chrome::kChromeUIHistoryURL)) {
+ if (url.spec() == chrome::kChromeUIHistoryURL) {
// The history page is treated specially as we want it to trigger syncable
// events for UI purposes.
return true;

Powered by Google App Engine
This is Rietveld 408576698