chrome/browser/prerender/prerender_manager.cc - Issue 2409423005: Compare GURLs to kUrlConstants with .spec() and string equality

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/prerender/prerender_manager.cc

Issue 2409423005: Compare GURLs to kUrlConstants with .spec() and string equality (Closed)

Patch Set: git cl format Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/prerender/prerender_manager.cc

diff --git a/chrome/browser/prerender/prerender_manager.cc b/chrome/browser/prerender/prerender_manager.cc

index 5d3bf457b1d8d35ac5971e504204f4255e9980a2..226ae5617334b3fe2e924ca3534195458d2a2159 100644

--- a/chrome/browser/prerender/prerender_manager.cc

+++ b/chrome/browser/prerender/prerender_manager.cc

@@ -756,7 +756,7 @@ bool PrerenderManager::DoesURLHaveValidScheme(const GURL& url) {

// static

bool PrerenderManager::DoesSubresourceURLHaveValidScheme(const GURL& url) {

- return DoesURLHaveValidScheme(url) || url == GURL(url::kAboutBlankURL);

+ return DoesURLHaveValidScheme(url) || url.spec() == url::kAboutBlankURL;

}

std::unique_ptr<base::DictionaryValue> PrerenderManager::GetAsValue() const {