Use trampoline or handlified JSObject::SetLocalPropertyIgnoreAttributes.

Use trampoline or handlified JSObject::SetLocalPropertyIgnoreAttributes.

R=verwaest@chromium.org

Committed: http://code.google.com/p/v8/source/detail?r=16642

Committed: http://code.google.com/p/v8/source/detail?r=16686

[Toon Verwaest, 2013-09-11 09:50:24]

lgtm with comment

https://codereview.chromium.org/24093002/diff/1/src/runtime.cc
File src/runtime.cc (right):

https://codereview.chromium.org/24093002/diff/1/src/runtime.cc#newcode2283
src/runtime.cc:2283: JSObject::SetLocalPropertyIgnoreAttributes(global, name,
value,
Can you make the unhandlified, non-trampoline version private to ensure that
it's not used anywhere anymore (except by the static handlified wrapper)?

[Michael Starzinger, 2013-09-11 10:32:49]

Thanks for the review. Addressed comments. Landing.

https://codereview.chromium.org/24093002/diff/1/src/runtime.cc
File src/runtime.cc (right):

https://codereview.chromium.org/24093002/diff/1/src/runtime.cc#newcode2283
src/runtime.cc:2283: JSObject::SetLocalPropertyIgnoreAttributes(global, name,
value,
On 2013/09/11 09:50:25, Toon Verwaest wrote:
> Can you make the unhandlified, non-trampoline version private to ensure that
> it's not used anywhere anymore (except by the static handlified wrapper)?

Done.

[Michael Starzinger, 2013-09-11 10:47:01]

Committed patchset #2 manually as r16642 (presubmit successful).

[Michael Starzinger, 2013-09-12 13:28:14]

Committed patchset #2 manually as r16686 (presubmit successful).