Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(291)

Side by Side Diff: src/objects.h

Issue 24093002: Use trampoline or handlified JSObject::SetLocalPropertyIgnoreAttributes. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Addressed comments by Toon Verwaest. Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/heap.cc ('k') | src/runtime.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 2170 matching lines...) Expand 10 before | Expand all | Expand 10 after
2181 static void AllocateStorageForMap(Handle<JSObject> object, Handle<Map> map); 2181 static void AllocateStorageForMap(Handle<JSObject> object, Handle<Map> map);
2182 inline MUST_USE_RESULT MaybeObject* AllocateStorageForMap(Map* map); 2182 inline MUST_USE_RESULT MaybeObject* AllocateStorageForMap(Map* map);
2183 2183
2184 static void MigrateInstance(Handle<JSObject> instance); 2184 static void MigrateInstance(Handle<JSObject> instance);
2185 inline MUST_USE_RESULT MaybeObject* MigrateInstance(); 2185 inline MUST_USE_RESULT MaybeObject* MigrateInstance();
2186 2186
2187 static Handle<Object> TryMigrateInstance(Handle<JSObject> instance); 2187 static Handle<Object> TryMigrateInstance(Handle<JSObject> instance);
2188 inline MUST_USE_RESULT MaybeObject* TryMigrateInstance(); 2188 inline MUST_USE_RESULT MaybeObject* TryMigrateInstance();
2189 2189
2190 // Can cause GC. 2190 // Can cause GC.
2191 MUST_USE_RESULT MaybeObject* SetLocalPropertyIgnoreAttributes(
2192 Name* key,
2193 Object* value,
2194 PropertyAttributes attributes,
2195 ValueType value_type = OPTIMAL_REPRESENTATION,
2196 StoreMode mode = ALLOW_AS_CONSTANT,
2197 ExtensibilityCheck extensibility_check = PERFORM_EXTENSIBILITY_CHECK);
2198 MUST_USE_RESULT MaybeObject* SetLocalPropertyIgnoreAttributesTrampoline( 2191 MUST_USE_RESULT MaybeObject* SetLocalPropertyIgnoreAttributesTrampoline(
2199 Name* key, 2192 Name* key,
2200 Object* value, 2193 Object* value,
2201 PropertyAttributes attributes, 2194 PropertyAttributes attributes,
2202 ValueType value_type = OPTIMAL_REPRESENTATION, 2195 ValueType value_type = OPTIMAL_REPRESENTATION,
2203 StoreMode mode = ALLOW_AS_CONSTANT, 2196 StoreMode mode = ALLOW_AS_CONSTANT,
2204 ExtensibilityCheck extensibility_check = PERFORM_EXTENSIBILITY_CHECK); 2197 ExtensibilityCheck extensibility_check = PERFORM_EXTENSIBILITY_CHECK);
2205 2198
2206 // Retrieve a value in a normalized object given a lookup result. 2199 // Retrieve a value in a normalized object given a lookup result.
2207 // Handles the special representation of JS global objects. 2200 // Handles the special representation of JS global objects.
(...skipping 521 matching lines...) Expand 10 before | Expand all | Expand 10 after
2729 Handle<Name> name, 2722 Handle<Name> name,
2730 Handle<Object> old_value); 2723 Handle<Object> old_value);
2731 2724
2732 // Deliver change records to observers. May cause GC. 2725 // Deliver change records to observers. May cause GC.
2733 static void DeliverChangeRecords(Isolate* isolate); 2726 static void DeliverChangeRecords(Isolate* isolate);
2734 2727
2735 private: 2728 private:
2736 friend class DictionaryElementsAccessor; 2729 friend class DictionaryElementsAccessor;
2737 friend class JSReceiver; 2730 friend class JSReceiver;
2738 2731
2732 // TODO(mstarzinger): Soon to be handlified.
2733 MUST_USE_RESULT MaybeObject* SetLocalPropertyIgnoreAttributes(
2734 Name* key,
2735 Object* value,
2736 PropertyAttributes attributes,
2737 ValueType value_type = OPTIMAL_REPRESENTATION,
2738 StoreMode mode = ALLOW_AS_CONSTANT,
2739 ExtensibilityCheck extensibility_check = PERFORM_EXTENSIBILITY_CHECK);
2740
2739 MUST_USE_RESULT MaybeObject* GetElementWithCallback(Object* receiver, 2741 MUST_USE_RESULT MaybeObject* GetElementWithCallback(Object* receiver,
2740 Object* structure, 2742 Object* structure,
2741 uint32_t index, 2743 uint32_t index,
2742 Object* holder); 2744 Object* holder);
2743 MUST_USE_RESULT PropertyAttributes GetElementAttributeWithInterceptor( 2745 MUST_USE_RESULT PropertyAttributes GetElementAttributeWithInterceptor(
2744 JSReceiver* receiver, 2746 JSReceiver* receiver,
2745 uint32_t index, 2747 uint32_t index,
2746 bool continue_search); 2748 bool continue_search);
2747 MUST_USE_RESULT PropertyAttributes GetElementAttributeWithoutInterceptor( 2749 MUST_USE_RESULT PropertyAttributes GetElementAttributeWithoutInterceptor(
2748 JSReceiver* receiver, 2750 JSReceiver* receiver,
(...skipping 7473 matching lines...) Expand 10 before | Expand all | Expand 10 after
10222 } else { 10224 } else {
10223 value &= ~(1 << bit_position); 10225 value &= ~(1 << bit_position);
10224 } 10226 }
10225 return value; 10227 return value;
10226 } 10228 }
10227 }; 10229 };
10228 10230
10229 } } // namespace v8::internal 10231 } } // namespace v8::internal
10230 10232
10231 #endif // V8_OBJECTS_H_ 10233 #endif // V8_OBJECTS_H_
OLDNEW
« no previous file with comments | « src/heap.cc ('k') | src/runtime.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698