Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2409283002: Rename fpdf_page_doc.cpp -> cpdf_docpagedata.h (Closed)

Created:
4 years, 2 months ago by Tom Sepez
Modified:
4 years, 2 months ago
Reviewers:
dsinclair
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Rename fpdf_page_doc.cpp -> cpdf_docpagedata.h Committed: https://pdfium.googlesource.com/pdfium/+/9fa95efa11f211a6faf9b2adb27211f784aee89a

Patch Set 1 #

Patch Set 2 : 2016 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+108 lines, -621 lines) Patch
M BUILD.gn View 2 chunks +2 lines, -1 line 0 comments Download
M core/fpdfapi/cpdf_modulemgr.cpp View 1 chunk +4 lines, -0 lines 0 comments Download
M core/fpdfapi/edit/cpdf_pagecontentgenerator.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M core/fpdfapi/font/cpdf_font.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/page/cpdf_color.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M core/fpdfapi/page/cpdf_colorspace.cpp View 1 chunk +1 line, -1 line 0 comments Download
A core/fpdfapi/page/cpdf_docpagedata.h View 1 1 chunk +85 lines, -0 lines 0 comments Download
A + core/fpdfapi/page/cpdf_docpagedata.cpp View 2 chunks +1 line, -5 lines 0 comments Download
M core/fpdfapi/page/cpdf_image.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/page/cpdf_imageobject.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/page/cpdf_shadingobject.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/page/cpdf_shadingpattern.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M core/fpdfapi/page/cpdf_textstate.cpp View 1 chunk +1 line, -1 line 0 comments Download
D core/fpdfapi/page/fpdf_page_doc.cpp View 1 chunk +0 lines, -549 lines 0 comments Download
M core/fpdfapi/page/fpdf_page_parser.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M core/fpdfapi/page/fpdf_page_parser_old.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M core/fpdfapi/page/pageint.h View 1 chunk +0 lines, -58 lines 0 comments Download
M core/fpdfapi/parser/cpdf_document.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M core/fpdfapi/render/fpdf_render.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M core/fpdfapi/render/fpdf_render_image.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M core/fpdfapi/render/fpdf_render_loadimage.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/render/fpdf_render_text.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (7 generated)
Tom Sepez
Dan, quick rename. This has been bugging me for a while.
4 years, 2 months ago (2016-10-11 18:35:09 UTC) #2
dsinclair
lgtm Thanks, it's on my list to get to the rest of these .... but ...
4 years, 2 months ago (2016-10-11 19:29:10 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2409283002/20001
4 years, 2 months ago (2016-10-11 19:29:21 UTC) #9
commit-bot: I haz the power
4 years, 2 months ago (2016-10-11 19:29:42 UTC) #11
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/9fa95efa11f211a6faf9b2adb27211f784ae...

Powered by Google App Engine
This is Rietveld 408576698