Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(256)

Issue 2409273002: QuicChromiumClientStream handle Read() after trailers are received but not yet delivered (Closed)

Created:
4 years, 2 months ago by xunjieli
Modified:
4 years, 2 months ago
Reviewers:
Zhongyi Shi
CC:
chromium-reviews, cbentzel+watch_chromium.org
Target Ref:
refs/pending/branch-heads/2883
Project:
chromium
Visibility:
Public.

Description

QuicChromiumClientStream handle Read() after trailers are received but not yet delivered This CL changes QuicChromiumClientStream::Read() to return ERR_IO_PENDNG if trailers are received but not yet delivered. This CL additionally posts a OnDataAvailable task when trailers are delivered so as to notify delegate of the FIN flag. BUG=652935 NOPRESUBMIT=true NOTRY=true TBR=zhongyi@chromium.org Review-Url: https://codereview.chromium.org/2405523002 Cr-Commit-Position: refs/heads/master@{#424183} (cherry picked from commit ec0ed02ab197a731d3dcccdd7379c71a057353a1)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+111 lines, -15 lines) Patch
M net/quic/chromium/bidirectional_stream_quic_impl.cc View 1 chunk +2 lines, -13 lines 0 comments Download
M net/quic/chromium/bidirectional_stream_quic_impl_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/chromium/quic_chromium_client_stream.cc View 3 chunks +9 lines, -2 lines 0 comments Download
M net/quic/chromium/quic_chromium_client_stream_test.cc View 3 chunks +99 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
xunjieli
4 years, 2 months ago (2016-10-11 18:05:51 UTC) #1
Zhongyi Shi
lgtm
4 years, 2 months ago (2016-10-11 18:20:31 UTC) #2
Zhongyi Shi
lgtm
4 years, 2 months ago (2016-10-11 18:20:32 UTC) #3
xunjieli
On 2016/10/11 18:20:32, Zhongyi Shi wrote: > lgtm Thanks! Compiled net_unittests locally and made sure ...
4 years, 2 months ago (2016-10-11 18:24:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2409273002/1
4 years, 2 months ago (2016-10-11 18:25:01 UTC) #6
commit-bot: I haz the power
4 years, 2 months ago (2016-10-11 18:27:32 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1)

Powered by Google App Engine
This is Rietveld 408576698