Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(461)

Unified Diff: net/quic/chromium/bidirectional_stream_quic_impl.cc

Issue 2409273002: QuicChromiumClientStream handle Read() after trailers are received but not yet delivered (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | net/quic/chromium/bidirectional_stream_quic_impl_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/chromium/bidirectional_stream_quic_impl.cc
diff --git a/net/quic/chromium/bidirectional_stream_quic_impl.cc b/net/quic/chromium/bidirectional_stream_quic_impl.cc
index 0fb1119f5700407871a8d315faf92282cc19145a..e46675211b48f44aa81edd81f1531727f06c95b9 100644
--- a/net/quic/chromium/bidirectional_stream_quic_impl.cc
+++ b/net/quic/chromium/bidirectional_stream_quic_impl.cc
@@ -241,19 +241,8 @@ void BidirectionalStreamQuicImpl::OnHeadersAvailable(
if (delegate_)
delegate_->OnHeadersReceived(headers);
} else {
- if (stream_->IsDoneReading()) {
- // If the write side is closed, OnFinRead() will call
- // BidirectionalStreamQuicImpl::OnClose().
- stream_->OnFinRead();
- }
- if (!delegate_)
- return;
- // Complete any remaining read. The task is posted because
- // |delegate_|->OnTrailersReceived() might destroy |this|.
- base::ThreadTaskRunnerHandle::Get()->PostTask(
- FROM_HERE, base::Bind(&BidirectionalStreamQuicImpl::OnDataAvailable,
- weak_factory_.GetWeakPtr()));
- delegate_->OnTrailersReceived(headers);
+ if (delegate_)
+ delegate_->OnTrailersReceived(headers);
// |this| can be destroyed after this point.
}
}
« no previous file with comments | « no previous file | net/quic/chromium/bidirectional_stream_quic_impl_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698