Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(446)

Issue 2409263002: Revert of Add ThreadChecker for Ozone X11 GPU. (Closed)

Created:
4 years, 2 months ago by kylechar
Modified:
4 years, 2 months ago
Reviewers:
Fady Samuel, sadrul
CC:
chromium-reviews, kalyank, ozone-reviews_chromium.org, sadrul
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add ThreadChecker for Ozone X11 GPU. (patchset #1 id:1 of https://codereview.chromium.org/2366643002/ ) Reason for revert: Breaks multiple unit tests under Ozone X11. Original issue's description: > Add ThreadChecker for Ozone X11 GPU. > > Ensure Ozone X11 tests the same thread constraints we have in Ozone GBM. > > BUG=none > > Committed: https://crrev.com/0d77de2f5334b6d560487c5fd696178a3bfc3551 > Cr-Commit-Position: refs/heads/master@{#421817} TBR=sadrul@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=653976 Committed: https://crrev.com/e957ac9d29f16e67c5de264efe6f20c536a0ce51 Cr-Commit-Position: refs/heads/master@{#424594}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -8 lines) Patch
M ui/ozone/platform/x11/x11_surface_factory.h View 2 chunks +0 lines, -6 lines 0 comments Download
M ui/ozone/platform/x11/x11_surface_factory.cc View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
kylechar
Created Revert of Add ThreadChecker for Ozone X11 GPU.
4 years, 2 months ago (2016-10-11 18:02:52 UTC) #1
kylechar
4 years, 2 months ago (2016-10-11 18:03:58 UTC) #4
Fady Samuel
lgtm. Was this waiting on me? Reverts should be automatic.
4 years, 2 months ago (2016-10-11 21:59:30 UTC) #5
sadrul
Yeah, revert is TBR + cq lgtm
4 years, 2 months ago (2016-10-11 23:11:38 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2409263002/1
4 years, 2 months ago (2016-10-11 23:12:13 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-11 23:34:08 UTC) #11
commit-bot: I haz the power
4 years, 2 months ago (2016-10-11 23:40:21 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e957ac9d29f16e67c5de264efe6f20c536a0ce51
Cr-Commit-Position: refs/heads/master@{#424594}

Powered by Google App Engine
This is Rietveld 408576698