Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(29)

Issue 2409173003: Delete unused flags from CFX_SubstFont (Closed)

Created:
4 years, 1 month ago by npm
Modified:
4 years, 1 month ago
Reviewers:
Lei Zhang, dsinclair
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -17 lines) Patch
M core/fpdfapi/render/fpdf_render_text.cpp View 1 chunk +3 lines, -7 lines 0 comments Download
M core/fxge/cfx_substfont.h View 1 chunk +0 lines, -4 lines 2 comments Download
M core/fxge/ge/cfx_fontmapper.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M core/fxge/ge/cfx_renderdevice.cpp View 2 chunks +2 lines, -5 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
npm
PTAL
4 years, 1 month ago (2016-10-11 20:15:25 UTC) #4
dsinclair
https://codereview.chromium.org/2409173003/diff/1/core/fxge/cfx_substfont.h File core/fxge/cfx_substfont.h (left): https://codereview.chromium.org/2409173003/diff/1/core/fxge/cfx_substfont.h#oldcode13 core/fxge/cfx_substfont.h:13: #define FXFONT_SUBST_GLYPHPATH 0x04 Just to be sure, we don't ...
4 years, 1 month ago (2016-10-11 20:18:33 UTC) #5
npm
https://codereview.chromium.org/2409173003/diff/1/core/fxge/cfx_substfont.h File core/fxge/cfx_substfont.h (left): https://codereview.chromium.org/2409173003/diff/1/core/fxge/cfx_substfont.h#oldcode13 core/fxge/cfx_substfont.h:13: #define FXFONT_SUBST_GLYPHPATH 0x04 On 2016/10/11 20:18:33, dsinclair wrote: > ...
4 years, 1 month ago (2016-10-11 20:29:44 UTC) #8
dsinclair
lgtm. Thanks a lot for checking.
4 years, 1 month ago (2016-10-11 20:30:57 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2409173003/1
4 years, 1 month ago (2016-10-11 21:50:43 UTC) #11
commit-bot: I haz the power
4 years, 1 month ago (2016-10-11 21:51:04 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/2bfa222a38e12a5108899a9d9b5a9b2179dc...

Powered by Google App Engine
This is Rietveld 408576698