core/fxge/cfx_substfont.h - Issue 2409173003: Delete unused flags from CFX_SubstFont

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: core/fxge/cfx_substfont.h

Issue 2409173003: Delete unused flags from CFX_SubstFont (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 // Copyright 2016 PDFium Authors. All rights reserved.	1 // Copyright 2016 PDFium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com	5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com

6	6

7 #ifndef CORE_FXGE_CFX_SUBSTFONT_H_	7 #ifndef CORE_FXGE_CFX_SUBSTFONT_H_

8 #define CORE_FXGE_CFX_SUBSTFONT_H_	8 #define CORE_FXGE_CFX_SUBSTFONT_H_

9	9

10 #include "core/fxcrt/fx_string.h"	10 #include "core/fxcrt/fx_string.h"

11	11

12 #define FXFONT_SUBST_MM 0x01	12 #define FXFONT_SUBST_MM 0x01

13 #define FXFONT_SUBST_GLYPHPATH 0x04
dsinclair 2016/10/11 20:18:33 Just to be sure, we don't have another define whic Just to be sure, we don't have another define which has the same value that we're setting into the flag do we? npm 2016/10/11 20:29:44 git grep m_SubstFlags shows it's only \|= with FXFO Show quoted text On 2016/10/11 20:18:33, dsinclair wrote: > Just to be sure, we don't have another define which has the same value that > we're setting into the flag do we? git grep m_SubstFlags shows it's only \|= with FXFONT_SUBST_MM, FXFONT_SUBST_EXACT, and in xfa FXFONT_SUBST_ITALIC (0x02)
14 #define FXFONT_SUBST_CLEARTYPE 0x08

15 #define FXFONT_SUBST_TRANSFORM 0x10

16 #define FXFONT_SUBST_NONSYMBOL 0x20

17 #define FXFONT_SUBST_EXACT 0x40	13 #define FXFONT_SUBST_EXACT 0x40

18	14

19 class CFX_SubstFont {	15 class CFX_SubstFont {

20 public:	16 public:

21 CFX_SubstFont();	17 CFX_SubstFont();

22	18

23 CFX_ByteString m_Family;	19 CFX_ByteString m_Family;

24 int m_Charset;	20 int m_Charset;

25 uint32_t m_SubstFlags;	21 uint32_t m_SubstFlags;

26 int m_Weight;	22 int m_Weight;

27 int m_ItalicAngle;	23 int m_ItalicAngle;

28 bool m_bSubstCJK;	24 bool m_bSubstCJK;

29 int m_WeightCJK;	25 int m_WeightCJK;

30 bool m_bItalicCJK;	26 bool m_bItalicCJK;

31 };	27 };

32	28

33 #endif // CORE_FXGE_CFX_SUBSTFONT_H_	29 #endif // CORE_FXGE_CFX_SUBSTFONT_H_

OLD	NEW

« no previous file with comments | « core/fpdfapi/render/fpdf_render_text.cpp ('k') | core/fxge/ge/cfx_fontmapper.cpp » ('j') | no next file with comments »