Remove kEnablePasswordChangeSupport and clean-up form_autofill_util.cc

components/autofill/content/renderer/form_autofill_util.cc

Index: components/autofill/content/renderer/form_autofill_util.cc
diff --git a/components/autofill/content/renderer/form_autofill_util.cc b/components/autofill/content/renderer/form_autofill_util.cc
index 3f31d7495e8237e3d0a5609a6afcb76ce9087696..e2b2134ba039578968583a3ad027100c120bc57a 100644
--- a/components/autofill/content/renderer/form_autofill_util.cc
+++ b/components/autofill/content/renderer/form_autofill_util.cc
@@ -1213,13 +1213,11 @@ bool IsFormVisible(blink::WebFrame* frame,
   blink::WebVector<WebFormElement> forms;
   frame->document().forms(forms);
 
-#if !defined(OS_ANDROID)
   // Omitting the action attribute would result in |canonical_origin| for
   // hierarchical schemes like http:, and in an empty URL for non-hierarchical
   // schemes like about: or data: etc.
   const bool action_is_empty = canonical_action.is_empty()
                                || canonical_action == canonical_origin;
-#endif
 
   // Since empty or unspecified action fields are automatically set to page URL,
   // action field for forms cannot be used for comparing (all forms with
@@ -1232,7 +1230,6 @@ bool IsFormVisible(blink::WebFrame* frame,
       continue;
 
     GURL iter_canonical_action = GetCanonicalActionForForm(form);
-#if !defined(OS_ANDROID)
     bool form_action_is_empty = iter_canonical_action.is_empty() ||
                                 iter_canonical_action == frame_origin;
     if (action_is_empty != form_action_is_empty)
@@ -1250,13 +1247,10 @@ bool IsFormVisible(blink::WebFrame* frame,
         return true;  // Form still exists.
       }
     }
-#else  // OS_ANDROID
     if (canonical_action == iter_canonical_action) {

[vabr (Chromium), 2016/10/11 12:29:54]

You need to remove the whole old OS_ANDROID block, because you just replace it
with the non-Android block. Don't leave both in.

       return true;  // Form still exists.
     }
-#endif
   }
-
   return false;
 }