Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3408)

Unified Diff: chrome/browser/about_flags.cc

Issue 2409123002: Remove kEnablePasswordChangeSupport and clean-up form_autofill_util.cc (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/about_flags.cc
diff --git a/chrome/browser/about_flags.cc b/chrome/browser/about_flags.cc
index d218902bb26e405ddc2012ec821063a88f3c08b8..f8fcafc87a638a43ad15b0906020c06d3490f058 100644
--- a/chrome/browser/about_flags.cc
+++ b/chrome/browser/about_flags.cc
@@ -1003,10 +1003,6 @@ const FeatureEntry kFeatureEntries[] = {
IDS_FLAGS_AUTOMATIC_PASSWORD_SAVING_DESCRIPTION, kOsDesktop,
FEATURE_VALUE_TYPE(
password_manager::features::kEnableAutomaticPasswordSaving)},
- {"enable-password-change-support", IDS_FLAGS_PASSWORD_CHANGE_SUPPORT_NAME,
- IDS_FLAGS_PASSWORD_CHANGE_SUPPORT_DESCRIPTION, kOsAndroid,
- FEATURE_VALUE_TYPE(
- password_manager::features::kEnablePasswordChangeSupport)},
{"enable-password-force-saving", IDS_FLAGS_PASSWORD_FORCE_SAVING_NAME,
IDS_FLAGS_PASSWORD_FORCE_SAVING_DESCRIPTION, kOsAll,
FEATURE_VALUE_TYPE(
@@ -1518,9 +1514,9 @@ const FeatureEntry kFeatureEntries[] = {
MULTI_VALUE_TYPE(kDataReductionProxyLoFiChoices)},
{"enable-data-reduction-proxy-lite-page",
IDS_FLAGS_ENABLE_DATA_REDUCTION_PROXY_LITE_PAGE_NAME,
- IDS_FLAGS_ENABLE_DATA_REDUCTION_PROXY_LITE_PAGE_DESCRIPTION,
- kOsAll, SINGLE_VALUE_TYPE(data_reduction_proxy::switches::
- kEnableDataReductionProxyLitePage)},
+ IDS_FLAGS_ENABLE_DATA_REDUCTION_PROXY_LITE_PAGE_DESCRIPTION, kOsAll,
vabr (Chromium) 2016/10/11 12:29:54 nit: Please remove the changes on this line and be
+ SINGLE_VALUE_TYPE(
+ data_reduction_proxy::switches::kEnableDataReductionProxyLitePage)},
{"clear-data-reduction-proxy-data-savings",
IDS_FLAGS_DATA_REDUCTION_PROXY_RESET_SAVINGS_NAME,
IDS_FLAGS_DATA_REDUCTION_PROXY_RESET_SAVINGS_DESCRIPTION, kOsAll,
@@ -2055,8 +2051,7 @@ const FeatureEntry kFeatureEntries[] = {
IDS_FLAGS_MATERIAL_SECURITY_VERBOSE_DESCRIPTION, kOsDesktop,
MULTI_VALUE_TYPE(kSecurityVerboseChoices)},
#if defined(OS_CHROMEOS)
- {"arc-boot-completed-broadcast",
- IDS_FLAGS_ARC_BOOT_COMPLETED,
+ {"arc-boot-completed-broadcast", IDS_FLAGS_ARC_BOOT_COMPLETED,
IDS_FLAGS_ARC_BOOT_COMPLETED_DESCRIPTION, kOsCrOS,
FEATURE_VALUE_TYPE(arc::kBootCompletedBroadcastFeature)},
#endif
@@ -2065,8 +2060,8 @@ const FeatureEntry kFeatureEntries[] = {
IDS_FLAGS_DISABLE_WINRT_MIDI_API_DESCRIPTION, kOsWin,
SINGLE_DISABLE_VALUE_TYPE(switches::kDisableWinrtMidiApi)},
#endif // OS_WIN
- // NOTE: Adding new command-line switches requires adding corresponding
- // entries to enum "LoginCustomFlags" in histograms.xml. See note in
+ // NOTE: Adding new command-line switches requires adding corresponding
+ // entries to enum "LoginCustomFlags" in histograms.xml. See note in
// histograms.xml and don't forget to run AboutFlagsHistogramTest unit test.
};

Powered by Google App Engine
This is Rietveld 408576698