Remove kEnablePasswordChangeSupport and clean-up form_autofill_util.cc

Remove kEnablePasswordChangeSupport and clean-up form_autofill_util.cc

password_manager::features::kEnablePasswordChangeSupport is defined
but not used in Chromium any more. Change password support is now
always on also on Android, including the "update password" prompt.
Therefore also Android-specific handling inside
autofill::form_util::IsFormVisible is outdated, Android should do
what other platforms do.

This CL removes the unused feature, and also makes IsFormVisible copy
desktop behaviour on Android.

Committed: https://crrev.com/3a03743c7be2c81af3390823488db30fa7c1dd29
Cr-Commit-Position: refs/heads/master@{#424708}

[Yeol Park, 2016-10-11 12:04:56]

Description was changed from

==========
password_manager::features::kEnablePasswordChangeSupport is
no longer used since r414350, we should remove it completely.

Also, in components/autofill/content/renderer/form_autofill_util.cc,
IsFormVisible still contains code excluded from OS_ANDROID.

This code can potentially lead to Chrome understanding more submission
events as success (by returning false).

The code was not used on Android when Android did not have
the "Update password?" prompt, to protect users from rewriting a good credential
by some misunderstood other content.

Now that Android has the update prompt,
there is no need for running different checks on Android,
and we should remove the non-Android #ifdefs.

BUG=654406
==========

to

==========
password_manager::features::kEnablePasswordChangeSupport is
no longer used since r414350, we should remove it completely.

Also, in components/autofill/content/renderer/form_autofill_util.cc,
IsFormVisible still contains code excluded from OS_ANDROID.

This code can potentially lead to Chrome understanding more submission
events as success (by returning false).

The code was not used on Android when Android did not have
the "Update password?" prompt, to protect users from rewriting a good credential
by some misunderstood other content.

Now that Android has the update prompt,
there is no need for running different checks on Android,
and we should remove the non-Android #ifdefs.

BUG=654406
==========

[Yeol Park, 2016-10-11 12:04:56]

peary2@gmail.com changed reviewers:
+ creis@chromium.org, dvadym@chromium.org, vabr@chromium.org

[Yeol Park, 2016-10-11 12:06:29]

PTAL :)

[vabr (Chromium), 2016-10-11 12:29:54]

Thanks for the patch.

In addition to the comments below, please fix the CL description. Currently it
just repeats what is said on the bug, and the title is incomplete. Please follow
the guidelines below:

(1) The "Subject" needs to he a very short summary (1 line, ideally < 80
characters) of the CL.
(2) The first line of "Description" needs to be the summary just repeated,
because the landing Git commit is only created from the Description.
(3) The second line of Description needs to be blank.
(3) The third and further lines of the description need to have at most 80
characters each, and provide the following 2 pieces of information:
    (3a) Description of the current state, and why it needs a change. Something
like:
         password_manager::features::kEnablePasswordChangeSupport is defined
         but not used in Chromium any more. Change password support is now
         always on also on Android, including the "update password" prompt.
         Therefore also Android-specific handling inside
         autofill::form_util::IsFormVisible is outdated, Android should do
         what other platforms do.
    (3b) Description of what this CL changes:
         This CL removes the unused feature, and also makes IsFormVisible copy
         desktop behaviour on Android.


Thanks!
Vaclav

https://codereview.chromium.org/2409123002/diff/1/chrome/browser/about_flags.cc
File chrome/browser/about_flags.cc (right):

https://codereview.chromium.org/2409123002/diff/1/chrome/browser/about_flags....
chrome/browser/about_flags.cc:1517:
IDS_FLAGS_ENABLE_DATA_REDUCTION_PROXY_LITE_PAGE_DESCRIPTION, kOsAll,
nit: Please remove the changes on this line and below at 2063-2064. They are not
related to the rest of this CL, and would only make looking up code history
harder.

https://codereview.chromium.org/2409123002/diff/1/components/autofill/content...
File components/autofill/content/renderer/form_autofill_util.cc (left):

https://codereview.chromium.org/2409123002/diff/1/components/autofill/content...
components/autofill/content/renderer/form_autofill_util.cc:1254: if
(canonical_action == iter_canonical_action) {
You need to remove the whole old OS_ANDROID block, because you just replace it
with the non-Android block. Don't leave both in.

[Yeol Park, 2016-10-12 02:54:41]

Description was changed from

==========
password_manager::features::kEnablePasswordChangeSupport is
no longer used since r414350, we should remove it completely.

Also, in components/autofill/content/renderer/form_autofill_util.cc,
IsFormVisible still contains code excluded from OS_ANDROID.

This code can potentially lead to Chrome understanding more submission
events as success (by returning false).

The code was not used on Android when Android did not have
the "Update password?" prompt, to protect users from rewriting a good credential
by some misunderstood other content.

Now that Android has the update prompt,
there is no need for running different checks on Android,
and we should remove the non-Android #ifdefs.

BUG=654406
==========

to

==========
password_manager::features::kEnablePasswordChangeSupport is defined
but not used in Chromium any more. Change password support is now
always on also on Android, including the "update password" prompt.
Therefore also Android-specific handling inside
autofill::form_util::IsFormVisible is outdated, Android should do
what other platforms do.

This CL removes the unused feature, and also makes IsFormVisible copy
desktop behaviour on Android.
==========

[Yeol Park, 2016-10-12 02:56:48]

Description was changed from

==========
password_manager::features::kEnablePasswordChangeSupport is defined
but not used in Chromium any more. Change password support is now
always on also on Android, including the "update password" prompt.
Therefore also Android-specific handling inside
autofill::form_util::IsFormVisible is outdated, Android should do
what other platforms do.

This CL removes the unused feature, and also makes IsFormVisible copy
desktop behaviour on Android.
==========

to

==========
Remove kEnablePasswordChangeSupport and clean-up form_autofill_util.cc

password_manager::features::kEnablePasswordChangeSupport is defined
but not used in Chromium any more. Change password support is now
always on also on Android, including the "update password" prompt.
Therefore also Android-specific handling inside
autofill::form_util::IsFormVisible is outdated, Android should do
what other platforms do.

This CL removes the unused feature, and also makes IsFormVisible copy
desktop behaviour on Android.
==========

[Yeol Park, 2016-10-12 03:06:53]

Thank you for your information. :)
I have completed the update for my mistake.

[vabr (Chromium), 2016-10-12 08:03:09]

Thanks! This now LGTM.
Cheers,
Vaclav

[Yeol Park, 2016-10-12 08:08:46]

The CQ bit was checked by peary2@gmail.com

[commit-bot: I haz the power, 2016-10-12 08:09:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Yeol Park, 2016-10-12 08:09:04]

The CQ bit was unchecked by peary2@gmail.com

[Yeol Park, 2016-10-12 09:21:14]

Could you run build bot? :)

[vabr (Chromium), 2016-10-12 09:59:59]

The CQ bit was checked by vabr@chromium.org to run a CQ dry run

[vabr (Chromium), 2016-10-12 10:00:11]

The CQ bit was unchecked by vabr@chromium.org

[commit-bot: I haz the power, 2016-10-12 10:00:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[vabr (Chromium), 2016-10-12 10:00:14]

The CQ bit was checked by vabr@chromium.org

[commit-bot: I haz the power, 2016-10-12 10:00:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-12 10:45:38]

Description was changed from

==========
Remove kEnablePasswordChangeSupport and clean-up form_autofill_util.cc

password_manager::features::kEnablePasswordChangeSupport is defined
but not used in Chromium any more. Change password support is now
always on also on Android, including the "update password" prompt.
Therefore also Android-specific handling inside
autofill::form_util::IsFormVisible is outdated, Android should do
what other platforms do.

This CL removes the unused feature, and also makes IsFormVisible copy
desktop behaviour on Android.
==========

to

==========
Remove kEnablePasswordChangeSupport and clean-up form_autofill_util.cc

password_manager::features::kEnablePasswordChangeSupport is defined
but not used in Chromium any more. Change password support is now
always on also on Android, including the "update password" prompt.
Therefore also Android-specific handling inside
autofill::form_util::IsFormVisible is outdated, Android should do
what other platforms do.

This CL removes the unused feature, and also makes IsFormVisible copy
desktop behaviour on Android.
==========

[commit-bot: I haz the power, 2016-10-12 10:45:39]

Committed patchset #2 (id:20001)

[vabr (Chromium), 2016-10-12 10:47:51]

Description was changed from

==========
Remove kEnablePasswordChangeSupport and clean-up form_autofill_util.cc

password_manager::features::kEnablePasswordChangeSupport is defined
but not used in Chromium any more. Change password support is now
always on also on Android, including the "update password" prompt.
Therefore also Android-specific handling inside
autofill::form_util::IsFormVisible is outdated, Android should do
what other platforms do.

This CL removes the unused feature, and also makes IsFormVisible copy
desktop behaviour on Android.
==========

to

==========
Remove kEnablePasswordChangeSupport and clean-up form_autofill_util.cc

password_manager::features::kEnablePasswordChangeSupport is defined
but not used in Chromium any more. Change password support is now
always on also on Android, including the "update password" prompt.
Therefore also Android-specific handling inside
autofill::form_util::IsFormVisible is outdated, Android should do
what other platforms do.

This CL removes the unused feature, and also makes IsFormVisible copy
desktop behaviour on Android.

BUG=654406
==========

[commit-bot: I haz the power, 2016-10-12 10:47:57]

Description was changed from

==========
Remove kEnablePasswordChangeSupport and clean-up form_autofill_util.cc

password_manager::features::kEnablePasswordChangeSupport is defined
but not used in Chromium any more. Change password support is now
always on also on Android, including the "update password" prompt.
Therefore also Android-specific handling inside
autofill::form_util::IsFormVisible is outdated, Android should do
what other platforms do.

This CL removes the unused feature, and also makes IsFormVisible copy
desktop behaviour on Android.

BUG=654406
==========

to

==========
Remove kEnablePasswordChangeSupport and clean-up form_autofill_util.cc

password_manager::features::kEnablePasswordChangeSupport is defined
but not used in Chromium any more. Change password support is now
always on also on Android, including the "update password" prompt.
Therefore also Android-specific handling inside
autofill::form_util::IsFormVisible is outdated, Android should do
what other platforms do.

This CL removes the unused feature, and also makes IsFormVisible copy
desktop behaviour on Android.

Committed: https://crrev.com/3a03743c7be2c81af3390823488db30fa7c1dd29
Cr-Commit-Position: refs/heads/master@{#424708}
==========

[commit-bot: I haz the power, 2016-10-12 10:47:58]

Patchset 2 (id:??) landed as
https://crrev.com/3a03743c7be2c81af3390823488db30fa7c1dd29
Cr-Commit-Position: refs/heads/master@{#424708}