Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Unified Diff: components/autofill/content/renderer/form_autofill_util.cc

Issue 2409123002: Remove kEnablePasswordChangeSupport and clean-up form_autofill_util.cc (Closed)
Patch Set: Remove kEnablePasswordChangeSupport and clean-up form_autofill_util.cc Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/about_flags.cc ('k') | components/password_manager/core/common/password_manager_features.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/autofill/content/renderer/form_autofill_util.cc
diff --git a/components/autofill/content/renderer/form_autofill_util.cc b/components/autofill/content/renderer/form_autofill_util.cc
index 3f31d7495e8237e3d0a5609a6afcb76ce9087696..7731d9a2dfbe905a65fa0cc052eb15b03c3fdb8b 100644
--- a/components/autofill/content/renderer/form_autofill_util.cc
+++ b/components/autofill/content/renderer/form_autofill_util.cc
@@ -1213,13 +1213,11 @@ bool IsFormVisible(blink::WebFrame* frame,
blink::WebVector<WebFormElement> forms;
frame->document().forms(forms);
-#if !defined(OS_ANDROID)
// Omitting the action attribute would result in |canonical_origin| for
// hierarchical schemes like http:, and in an empty URL for non-hierarchical
// schemes like about: or data: etc.
const bool action_is_empty = canonical_action.is_empty()
|| canonical_action == canonical_origin;
-#endif
// Since empty or unspecified action fields are automatically set to page URL,
// action field for forms cannot be used for comparing (all forms with
@@ -1232,7 +1230,6 @@ bool IsFormVisible(blink::WebFrame* frame,
continue;
GURL iter_canonical_action = GetCanonicalActionForForm(form);
-#if !defined(OS_ANDROID)
bool form_action_is_empty = iter_canonical_action.is_empty() ||
iter_canonical_action == frame_origin;
if (action_is_empty != form_action_is_empty)
@@ -1250,11 +1247,6 @@ bool IsFormVisible(blink::WebFrame* frame,
return true; // Form still exists.
}
}
-#else // OS_ANDROID
- if (canonical_action == iter_canonical_action) {
- return true; // Form still exists.
- }
-#endif
}
return false;
« no previous file with comments | « chrome/browser/about_flags.cc ('k') | components/password_manager/core/common/password_manager_features.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698