Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Issue 2408933002: Allow the 'Advanced' button to act as an expandable toggle for a11y. (Closed)

Created:
4 years, 2 months ago by hcarmona
Modified:
4 years, 2 months ago
Reviewers:
dschuyler
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Allow the 'Advanced' button to act as an expandable toggle for a11y. BUG=626879 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/9760089f786eba7bcdfe7165d6cb012af41214f3 Cr-Commit-Position: refs/heads/master@{#424499}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M chrome/browser/resources/settings/settings_main/settings_main.html View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 13 (8 generated)
hcarmona
PTAL
4 years, 2 months ago (2016-10-11 14:06:43 UTC) #7
dschuyler
lgtm
4 years, 2 months ago (2016-10-11 18:27:35 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2408933002/1
4 years, 2 months ago (2016-10-11 18:47:54 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-11 18:58:38 UTC) #11
commit-bot: I haz the power
4 years, 2 months ago (2016-10-11 19:00:12 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9760089f786eba7bcdfe7165d6cb012af41214f3
Cr-Commit-Position: refs/heads/master@{#424499}

Powered by Google App Engine
This is Rietveld 408576698