chrome/browser/resources/settings/settings_main/settings_main.html - Issue 2408933002: Allow the 'Advanced' button to act as an expandable toggle for a11y.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/settings_main/settings_main.html

Issue 2408933002: Allow the 'Advanced' button to act as an expandable toggle for a11y. (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/resources/settings/settings_main/settings_main.html

diff --git a/chrome/browser/resources/settings/settings_main/settings_main.html b/chrome/browser/resources/settings/settings_main/settings_main.html

index ba150265bbf664a853b123e0b2391f994f8f5a71..4ca98a267b203e99fe51da022e0b5b616c9d173c 100644

--- a/chrome/browser/resources/settings/settings_main/settings_main.html

+++ b/chrome/browser/resources/settings/settings_main/settings_main.html

@@ -78,7 +78,9 @@

showPages_.basic, hasExpandedSection_, inSearchMode_)]]">

- <paper-button id="advancedToggle" on-tap="toggleAdvancedPage_">

+ <paper-button id="advancedToggle" on-tap="toggleAdvancedPage_" toggles

+ active="[[advancedToggleExpanded_]]"

+ aria-active-attribute="aria-expanded">

<span>$i18n{advancedPageTitle}</span>

<iron-icon icon="[[arrowState_(advancedToggleExpanded_)]]">

</iron-icon>

« no previous file with comments | « no previous file | no next file » | no next file with comments »