Parse the 'patches' argument in SDK libraries declarations.

Parse the 'patches' argument in SDK libraries declarations.

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Committed: https://github.com/dart-lang/sdk/commit/1a70ff791afc907c5d9029f55a2c0ce7a8b80879

[Paul Berry, 2016-10-10 19:14:38]

https://codereview.chromium.org/2408863002/diff/1/pkg/analyzer/lib/src/genera...
File pkg/analyzer/lib/src/generated/sdk.dart (right):

https://codereview.chromium.org/2408863002/diff/1/pkg/analyzer/lib/src/genera...
pkg/analyzer/lib/src/generated/sdk.dart:417: if (key is SimpleIdentifier &&
value is SimpleStringLiteral) {
Two issues:

1. The "patches" parameter should be a Map<int, List<String>>, where the list is
a list of paths to patch files.  (This is necessary to accommodate the VM, which
has multiple patches per library).  This code is treating it as a Map<int,
String>.

2. In the long term we'll need to accept keys of the form `PLATFORM1 | PLATFORM2
| PLATFORM3` (so that we can share most patch files between Dart2js and DDC). 
If you just want to add a TODO comment for now, that's fine with me.

https://codereview.chromium.org/2408863002/diff/1/pkg/analyzer/test/src/dart/...
File pkg/analyzer/test/src/dart/sdk/sdk_test.dart (right):

https://codereview.chromium.org/2408863002/diff/1/pkg/analyzer/test/src/dart/...
pkg/analyzer/test/src/dart/sdk/sdk_test.dart:486: VM_PLATFORM:
'foo/foo_vm_patch.dart',
Since "patches" should be a Map<int, List<String>>, this needs to change to:

VM_PLATFORM: ['foo/foo_vm_patch.dart'],

(Similar changes elsewhere in this file).

[scheglov, 2016-10-10 19:41:52]

PTAL

https://codereview.chromium.org/2408863002/diff/1/pkg/analyzer/lib/src/genera...
File pkg/analyzer/lib/src/generated/sdk.dart (right):

https://codereview.chromium.org/2408863002/diff/1/pkg/analyzer/lib/src/genera...
pkg/analyzer/lib/src/generated/sdk.dart:417: if (key is SimpleIdentifier &&
value is SimpleStringLiteral) {
On 2016/10/10 19:14:38, Paul Berry wrote:
> Two issues:
> 
> 1. The "patches" parameter should be a Map<int, List<String>>, where the list
is
> a list of paths to patch files.  (This is necessary to accommodate the VM,
which
> has multiple patches per library).  This code is treating it as a Map<int,
> String>.
> 
> 2. In the long term we'll need to accept keys of the form `PLATFORM1 |
PLATFORM2
> | PLATFORM3` (so that we can share most patch files between Dart2js and DDC). 
> If you just want to add a TODO comment for now, that's fine with me.

OK, I see now.
The key of this map must be a combination of platforms.
Done.

https://codereview.chromium.org/2408863002/diff/1/pkg/analyzer/test/src/dart/...
File pkg/analyzer/test/src/dart/sdk/sdk_test.dart (right):

https://codereview.chromium.org/2408863002/diff/1/pkg/analyzer/test/src/dart/...
pkg/analyzer/test/src/dart/sdk/sdk_test.dart:486: VM_PLATFORM:
'foo/foo_vm_patch.dart',
On 2016/10/10 19:14:38, Paul Berry wrote:
> Since "patches" should be a Map<int, List<String>>, this needs to change to:
> 
> VM_PLATFORM: ['foo/foo_vm_patch.dart'],
> 
> (Similar changes elsewhere in this file).

Done.

[Brian Wilkerson, 2016-10-10 19:44:38]

lgtm

[Paul Berry, 2016-10-11 16:15:41]

lgtm

[scheglov, 2016-10-11 16:19:33]

Description was changed from

==========
Parse the 'patches' argument in SDK libraries declarations.

R=brianwilkerson@google.com, paulberry@google.com
BUG=
==========

to

==========
Parse the 'patches' argument in SDK libraries declarations.

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Committed:
https://github.com/dart-lang/sdk/commit/1a70ff791afc907c5d9029f55a2c0ce7a8b80879
==========

[scheglov, 2016-10-11 16:19:34]

Committed patchset #2 (id:20001) manually as
1a70ff791afc907c5d9029f55a2c0ce7a8b80879 (presubmit successful).

[Bill Hesse, 2016-10-11 21:35:58]

whesse@google.com changed reviewers:
+ whesse@google.com

[Bill Hesse, 2016-10-11 21:35:59]

https://codereview.chromium.org/2408863002/diff/20001/pkg/analyzer/lib/src/ge...
File pkg/analyzer/lib/src/generated/sdk.dart (right):

https://codereview.chromium.org/2408863002/diff/20001/pkg/analyzer/lib/src/ge...
pkg/analyzer/lib/src/generated/sdk.dart:549: List<String> getPatches(int
platform);
This is a breaking change to the interface.  You need to add an implementation
of this to package:linter.  This is showing up as an error in the analyzer bots.