Parse the 'patches' argument in SDK libraries declarations.

pkg/analyzer/test/src/dart/sdk/sdk_test.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library analyzer.test.generated.sdk_test;
 
 import 'package:analyzer/file_system/file_system.dart';
 import 'package:analyzer/file_system/memory_file_system.dart';
 import 'package:analyzer/src/context/builder.dart' show EmbedderYamlLocator;
 import 'package:analyzer/src/dart/sdk/sdk.dart';
 import 'package:analyzer/src/generated/engine.dart';
 import 'package:analyzer/src/generated/java_engine_io.dart';
 import 'package:analyzer/src/generated/sdk.dart';
 import 'package:analyzer/src/generated/source.dart';
 import 'package:analyzer/src/summary/summarize_elements.dart';
 import 'package:test/test.dart';
 import 'package:test_reflective_loader/test_reflective_loader.dart';
 
 import '../../../embedder_tests.dart';
 import '../../../generated/test_support.dart';
 import '../../../resource_utils.dart';
 
 main() {
   defineReflectiveSuite(() {
     defineReflectiveTests(EmbedderSdkTest);
     defineReflectiveTests(FolderBasedDartSdkTest);
     defineReflectiveTests(SdkExtensionFinderTest);
-    defineReflectiveTests(SDKLibrariesReaderTest);
+    defineReflectiveTests(SdkLibrariesReaderTest);
+    defineReflectiveTests(SdkLibraryImplTest);
   });
 }
 
 @reflectiveTest
 class EmbedderSdkTest extends EmbedderRelatedTest {
   void test_creation() {
     EmbedderYamlLocator locator = new EmbedderYamlLocator({
       'fox': <Folder>[pathTranslator.getResource(foxLib)]
     });
     EmbedderSdk sdk = new EmbedderSdk(resourceProvider, locator.embedderYamls);
@@ skipping 345 matching lines @@
     expect(urlMappings['dart:bear'],
         equals(resourceProvider.convertPath("/tmp/grizzly.dart")));
     expect(urlMappings['dart:relative'],
         equals(resourceProvider.convertPath("/relative.dart")));
     expect(urlMappings['dart:deep'],
         equals(resourceProvider.convertPath("/tmp/deep/directory/file.dart")));
   }
 }
 
 @reflectiveTest
-class SDKLibrariesReaderTest extends EngineTestCase {
+class SdkLibrariesReaderTest extends EngineTestCase {
   /**
    * The resource provider used by these tests.
    */
   MemoryResourceProvider resourceProvider;
 
   @override
   void setUp() {
     resourceProvider = new MemoryResourceProvider();
   }
 
@@ skipping 61 matching lines @@
     SdkLibrary second = libraryMap.getLibrary("dart:second");
     expect(second, isNotNull);
     expect(second.category, "Server");
     expect(second.path, "second/second.dart");
     expect(second.shortName, "dart:second");
     expect(second.isDart2JsLibrary, false);
     expect(second.isDocumented, false);
     expect(second.isImplementation, true);
     expect(second.isVmLibrary, false);
   }
+
+  void test_readFrom_patches() {
+    LibraryMap libraryMap = new SdkLibrariesReader(false).readFromFile(
+        resourceProvider.getFile('/libs.dart'),
+        r'''
+final Map<String, LibraryInfo> LIBRARIES = const <String, LibraryInfo> {
+  'foo' : const LibraryInfo(
+    'foo/foo.dart',
+    patches: {
+      VM_PLATFORM: 'foo/foo_vm_patch.dart',

[Paul Berry, 2016/10/10 19:14:38]

Since "patches" should be a Map<int, List<String>>, this needs to change to:

VM_PLATFORM: ['foo/foo_vm_patch.dart'],

(Similar changes elsewhere in this file).

[scheglov, 2016/10/10 19:41:52]

Done.

+      VM_PLATFORM: 'foo/bar_vm_patch.dart',
+      DART2JS_PLATFORM: '_internal/js_runtime/lib/foo_patch.dart'},
+    maturity: Maturity.STABLE),
+};''');
+    expect(libraryMap, isNotNull);
+    expect(libraryMap.size(), 1);
+    SdkLibrary library = libraryMap.getLibrary('dart:foo');
+    expect(library, isNotNull);
+    expect(library.path, 'foo/foo.dart');
+    expect(library.shortName, 'dart:foo');
+    expect(library.getPatches(SdkLibraryImpl.VM_PLATFORM),
+        unorderedEquals(['foo/foo_vm_patch.dart', 'foo/bar_vm_patch.dart']));
+    expect(library.getPatches(SdkLibraryImpl.DART2JS_PLATFORM),
+        unorderedEquals(['_internal/js_runtime/lib/foo_patch.dart']));
+  }
+
+  void test_readFrom_patches_invalid_unknownPlatform() {
+    expect(() {
+      new SdkLibrariesReader(false).readFromFile(
+          resourceProvider.getFile('/libs.dart'),
+          r'''
+final Map<String, LibraryInfo> LIBRARIES = const <String, LibraryInfo> {
+  'foo' : const LibraryInfo(
+    'foo/foo.dart',
+    patches: {
+      MY_UNKNOWN_PLATFORM: 'foo/bar_patch.dart'}),
+};''');
+    }, throwsArgumentError);
+  }
+
+  void test_readFrom_patches_no() {
+    LibraryMap libraryMap = new SdkLibrariesReader(false).readFromFile(
+        resourceProvider.getFile('/libs.dart'),
+        r'''
+final Map<String, LibraryInfo> LIBRARIES = const <String, LibraryInfo> {
+  'my' : const LibraryInfo('my/my.dart')
+};''');
+    expect(libraryMap, isNotNull);
+    expect(libraryMap.size(), 1);
+    SdkLibrary library = libraryMap.getLibrary('dart:my');
+    expect(library, isNotNull);
+    expect(library.path, 'my/my.dart');
+    expect(library.shortName, 'dart:my');
+    expect(library.getPatches(SdkLibraryImpl.VM_PLATFORM), isEmpty);
+    expect(library.getPatches(SdkLibraryImpl.DART2JS_PLATFORM), isEmpty);
+  }
 }
+
+@reflectiveTest
+class SdkLibraryImplTest extends EngineTestCase {
+  void test_patches() {
+    SdkLibraryImpl library = new SdkLibraryImpl('dart:async');
+    // Add patches.
+    library.addPatch(SdkLibraryImpl.VM_PLATFORM, 'async/async_vm_patch.dart');
+    library.addPatch(SdkLibraryImpl.VM_PLATFORM, 'async/timer_vm_patch.dart');
+    library.addPatch(SdkLibraryImpl.DART2JS_PLATFORM,
+        '_internal/js_runtime/lib/async_patch.dart');
+    // Get patches.
+    expect(
+        library.getPatches(SdkLibraryImpl.VM_PLATFORM),
+        unorderedEquals(
+            ['async/async_vm_patch.dart', 'async/timer_vm_patch.dart']));
+    expect(library.getPatches(SdkLibraryImpl.DART2JS_PLATFORM),
+        unorderedEquals(['_internal/js_runtime/lib/async_patch.dart']));
+  }
+}