[Extensions] Convert some ChromeSyncExtensionFunctions

[Extensions] Convert some ChromeSyncExtensionFunctions

SyncExtensionFunctions, AsyncExtensionFunctions,
ChromeSyncExtensionFunctions, and ChromeAsyncExtensionFunctions are
deprecated.

Remove ChromeSyncExtensionFunctions from:
- preference
- sessions

BUG=634140
Committed: https://crrev.com/456b28325156d9aa526d2c2fc02cb5ffedb07b4b
Cr-Commit-Position: refs/heads/master@{#424219}

[Devlin, 2016-10-10 16:36:50]

The CQ bit was checked by rdevlin.cronin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-10 16:37:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-10 16:49:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-10 16:49:12]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Devlin, 2016-10-10 17:12:27]

The CQ bit was checked by rdevlin.cronin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-10 17:12:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-10 17:45:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-10 17:45:42]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Devlin, 2016-10-10 18:44:46]

The CQ bit was checked by rdevlin.cronin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-10 18:45:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-10 19:26:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-10 19:26:01]

Dry run: This issue passed the CQ dry run.

[Devlin, 2016-10-10 19:27:08]

Patchset #2 (id:20001) has been deleted

[Devlin, 2016-10-10 19:27:14]

Patchset #2 (id:40001) has been deleted

[Devlin, 2016-10-10 19:27:20]

Patchset #1 (id:1) has been deleted

[Devlin, 2016-10-10 19:28:25]

rdevlin.cronin@chromium.org changed reviewers:
+ lazyboy@chromium.org

[Devlin, 2016-10-10 19:28:26]

lazyboy@, mind taking a look?

https://codereview.chromium.org/2408763002/diff/60001/chrome/browser/extensio...
File chrome/browser/extensions/api/preference/preference_api.cc (left):

https://codereview.chromium.org/2408763002/diff/60001/chrome/browser/extensio...
chrome/browser/extensions/api/preference/preference_api.cc:596:
EXTENSION_FUNCTION_VALIDATE(
Note: Removed this function because validation failures and errors are different
return types, and this function was trying to do both.  (it's also not much more
code to just inline it.)

[lazyboy, 2016-10-10 20:04:56]

lgtm

[Devlin, 2016-10-10 20:13:57]

The CQ bit was checked by rdevlin.cronin@chromium.org

[commit-bot: I haz the power, 2016-10-10 20:14:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-10 20:20:52]

Committed patchset #1 (id:60001)

[commit-bot: I haz the power, 2016-10-10 20:24:51]

Description was changed from

==========
[Extensions] Convert some ChromeSyncExtensionFunctions

SyncExtensionFunctions, AsyncExtensionFunctions,
ChromeSyncExtensionFunctions, and ChromeAsyncExtensionFunctions are
deprecated.

Remove ChromeSyncExtensionFunctions from:
- preference
- sessions

BUG=634140
==========

to

==========
[Extensions] Convert some ChromeSyncExtensionFunctions

SyncExtensionFunctions, AsyncExtensionFunctions,
ChromeSyncExtensionFunctions, and ChromeAsyncExtensionFunctions are
deprecated.

Remove ChromeSyncExtensionFunctions from:
- preference
- sessions

BUG=634140

Committed: https://crrev.com/456b28325156d9aa526d2c2fc02cb5ffedb07b4b
Cr-Commit-Position: refs/heads/master@{#424219}
==========

[commit-bot: I haz the power, 2016-10-10 20:24:52]

Patchset 1 (id:??) landed as
https://crrev.com/456b28325156d9aa526d2c2fc02cb5ffedb07b4b
Cr-Commit-Position: refs/heads/master@{#424219}