Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(680)

Unified Diff: chrome/browser/extensions/api/preference/preference_api.h

Issue 2408763002: [Extensions] Convert some ChromeSyncExtensionFunctions (Closed)
Patch Set: foo4 Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/preference/preference_api.h
diff --git a/chrome/browser/extensions/api/preference/preference_api.h b/chrome/browser/extensions/api/preference/preference_api.h
index f82bb8eba1a035fb25dd152202f5a2d093d68f77..47d68b4a576c3e21218935cc819ad2db33400f22 100644
--- a/chrome/browser/extensions/api/preference/preference_api.h
+++ b/chrome/browser/extensions/api/preference/preference_api.h
@@ -166,20 +166,11 @@ class PrefTransformerInterface {
// A base class to provide functionality common to the other *PreferenceFunction
// classes.
-class PreferenceFunction : public ChromeSyncExtensionFunction {
+class PreferenceFunction : public UIThreadExtensionFunction {
protected:
enum PermissionType { PERMISSION_TYPE_READ, PERMISSION_TYPE_WRITE };
~PreferenceFunction() override;
-
- // Given an |extension_pref_key|, provides its |browser_pref_key| from the
- // static map in preference_api.cc. Returns true if the corresponding
- // browser pref exists and the extension has the API permission needed to
- // modify that pref. Sets |error_| if the extension doesn't have the needed
- // permission.
- bool ValidateBrowserPref(const std::string& extension_pref_key,
- PermissionType permission_type,
- std::string* browser_pref_key);
};
class GetPreferenceFunction : public PreferenceFunction {
@@ -190,7 +181,7 @@ class GetPreferenceFunction : public PreferenceFunction {
~GetPreferenceFunction() override;
// ExtensionFunction:
- bool RunSync() override;
+ ResponseAction Run() override;
};
class SetPreferenceFunction : public PreferenceFunction {
@@ -201,7 +192,7 @@ class SetPreferenceFunction : public PreferenceFunction {
~SetPreferenceFunction() override;
// ExtensionFunction:
- bool RunSync() override;
+ ResponseAction Run() override;
};
class ClearPreferenceFunction : public PreferenceFunction {
@@ -213,7 +204,7 @@ class ClearPreferenceFunction : public PreferenceFunction {
~ClearPreferenceFunction() override;
// ExtensionFunction:
- bool RunSync() override;
+ ResponseAction Run() override;
};
} // namespace extensions

Powered by Google App Engine
This is Rietveld 408576698