Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6561)

Unified Diff: chrome/browser/ui/views/website_settings/permission_selector_row.cc

Issue 2408613002: Replace kPreferHtmlOverPlugins feature checks with PluginUtils::ShouldPreferHtmlOverPlugi… (Closed)
Patch Set: Replace remaining kPreferHtmlOverPlugins feature checks with PluginUtils::ShouldPreferHtmlOverPlugi… Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/website_settings/permission_selector_row.cc
diff --git a/chrome/browser/ui/views/website_settings/permission_selector_row.cc b/chrome/browser/ui/views/website_settings/permission_selector_row.cc
index 780e1f2c28b2ce3778ce720ab000e8d0dbe14317..188e36f4a109eef1d8fb8cc94c8edbde74083268 100644
--- a/chrome/browser/ui/views/website_settings/permission_selector_row.cc
+++ b/chrome/browser/ui/views/website_settings/permission_selector_row.cc
@@ -227,9 +227,10 @@ void PermissionCombobox::OnPerformAction(Combobox* combobox) {
///////////////////////////////////////////////////////////////////////////////
PermissionSelectorRow::PermissionSelectorRow(
+ Profile* profile,
const GURL& url,
const WebsiteSettingsUI::PermissionInfo& permission)
- : icon_(NULL), menu_button_(NULL), combobox_(NULL) {
+ : profile_(profile), icon_(NULL), menu_button_(NULL), combobox_(NULL) {
views::GridLayout* layout = new views::GridLayout(this);
SetLayoutManager(layout);
const int column_set_id = 0;
@@ -275,8 +276,7 @@ PermissionSelectorRow::PermissionSelectorRow(
views::GridLayout::CENTER);
// Create the menu model.
menu_model_.reset(new PermissionMenuModel(
- url,
- permission,
+ profile, url, permission,
base::Bind(&PermissionSelectorRow::PermissionChanged,
base::Unretained(this))));
@@ -329,8 +329,8 @@ void PermissionSelectorRow::InitializeMenuButtonView(
permission.source == content_settings::SETTING_SOURCE_USER;
menu_button_ = new internal::PermissionMenuButton(
WebsiteSettingsUI::PermissionActionToUIString(
- permission.type, permission.setting, permission.default_setting,
- permission.source),
+ profile_, permission.type, permission.setting,
+ permission.default_setting, permission.source),
menu_model_.get(), button_enabled);
menu_button_->SetEnabled(button_enabled);
menu_button_->SetAccessibleName(
@@ -347,10 +347,9 @@ void PermissionSelectorRow::InitializeComboboxView(
new internal::ComboboxModelAdapter(menu_model_.get()));
combobox_ = new internal::PermissionCombobox(
WebsiteSettingsUI::PermissionActionToUIString(
- permission.type, permission.setting, permission.default_setting,
- permission.source),
- combobox_model_adapter_.get(), button_enabled,
- true);
+ profile_, permission.type, permission.setting,
+ permission.default_setting, permission.source),
+ combobox_model_adapter_.get(), button_enabled, true);
combobox_->SetEnabled(button_enabled);
combobox_->SetAccessibleName(
WebsiteSettingsUI::PermissionTypeToUIString(permission.type));
@@ -366,8 +365,8 @@ void PermissionSelectorRow::PermissionChanged(
// Update the menu button text to reflect the new setting.
if (menu_button_) {
menu_button_->SetText(WebsiteSettingsUI::PermissionActionToUIString(
- permission.type, permission.setting, permission.default_setting,
- content_settings::SETTING_SOURCE_USER));
+ profile_, permission.type, permission.setting,
+ permission.default_setting, content_settings::SETTING_SOURCE_USER));
menu_button_->SizeToPreferredSize();
} else if (combobox_) {
bool use_default = permission.setting == CONTENT_SETTING_DEFAULT;

Powered by Google App Engine
This is Rietveld 408576698