Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(334)

Side by Side Diff: chrome/browser/ui/views/website_settings/permission_selector_row.cc

Issue 2408613002: Replace kPreferHtmlOverPlugins feature checks with PluginUtils::ShouldPreferHtmlOverPlugi… (Closed)
Patch Set: Replace remaining kPreferHtmlOverPlugins feature checks with PluginUtils::ShouldPreferHtmlOverPlugi… Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/views/website_settings/permission_selector_row.h" 5 #include "chrome/browser/ui/views/website_settings/permission_selector_row.h"
6 6
7 #include "base/i18n/rtl.h" 7 #include "base/i18n/rtl.h"
8 #include "base/macros.h" 8 #include "base/macros.h"
9 #include "base/strings/utf_string_conversions.h" 9 #include "base/strings/utf_string_conversions.h"
10 #include "chrome/browser/ui/views/website_settings/website_settings_popup_view.h " 10 #include "chrome/browser/ui/views/website_settings/website_settings_popup_view.h "
(...skipping 209 matching lines...) Expand 10 before | Expand all | Expand 10 after
220 model_->OnPerformAction(combobox->selected_index()); 220 model_->OnPerformAction(combobox->selected_index());
221 } 221 }
222 222
223 } // namespace internal 223 } // namespace internal
224 224
225 /////////////////////////////////////////////////////////////////////////////// 225 ///////////////////////////////////////////////////////////////////////////////
226 // PermissionSelectorRow 226 // PermissionSelectorRow
227 /////////////////////////////////////////////////////////////////////////////// 227 ///////////////////////////////////////////////////////////////////////////////
228 228
229 PermissionSelectorRow::PermissionSelectorRow( 229 PermissionSelectorRow::PermissionSelectorRow(
230 Profile* profile,
230 const GURL& url, 231 const GURL& url,
231 const WebsiteSettingsUI::PermissionInfo& permission) 232 const WebsiteSettingsUI::PermissionInfo& permission)
232 : icon_(NULL), menu_button_(NULL), combobox_(NULL) { 233 : profile_(profile), icon_(NULL), menu_button_(NULL), combobox_(NULL) {
233 views::GridLayout* layout = new views::GridLayout(this); 234 views::GridLayout* layout = new views::GridLayout(this);
234 SetLayoutManager(layout); 235 SetLayoutManager(layout);
235 const int column_set_id = 0; 236 const int column_set_id = 0;
236 views::ColumnSet* column_set = layout->AddColumnSet(column_set_id); 237 views::ColumnSet* column_set = layout->AddColumnSet(column_set_id);
237 column_set->AddColumn(views::GridLayout::FILL, 238 column_set->AddColumn(views::GridLayout::FILL,
238 views::GridLayout::FILL, 239 views::GridLayout::FILL,
239 1, 240 1,
240 views::GridLayout::FIXED, 241 views::GridLayout::FIXED,
241 kPermissionIconColumnWidth, 242 kPermissionIconColumnWidth,
242 0); 243 0);
(...skipping 25 matching lines...) Expand all
268 views::Label* label = new views::Label(l10n_util::GetStringFUTF16( 269 views::Label* label = new views::Label(l10n_util::GetStringFUTF16(
269 IDS_WEBSITE_SETTINGS_PERMISSION_TYPE, 270 IDS_WEBSITE_SETTINGS_PERMISSION_TYPE,
270 WebsiteSettingsUI::PermissionTypeToUIString(permission.type))); 271 WebsiteSettingsUI::PermissionTypeToUIString(permission.type)));
271 layout->AddView(label, 272 layout->AddView(label,
272 1, 273 1,
273 1, 274 1,
274 views::GridLayout::LEADING, 275 views::GridLayout::LEADING,
275 views::GridLayout::CENTER); 276 views::GridLayout::CENTER);
276 // Create the menu model. 277 // Create the menu model.
277 menu_model_.reset(new PermissionMenuModel( 278 menu_model_.reset(new PermissionMenuModel(
278 url, 279 profile, url, permission,
279 permission,
280 base::Bind(&PermissionSelectorRow::PermissionChanged, 280 base::Bind(&PermissionSelectorRow::PermissionChanged,
281 base::Unretained(this)))); 281 base::Unretained(this))));
282 282
283 // Create the permission menu button. 283 // Create the permission menu button.
284 #if defined(OS_MACOSX) 284 #if defined(OS_MACOSX)
285 bool use_real_combobox = true; 285 bool use_real_combobox = true;
286 #else 286 #else
287 bool use_real_combobox = 287 bool use_real_combobox =
288 ui::MaterialDesignController::IsSecondaryUiMaterial(); 288 ui::MaterialDesignController::IsSecondaryUiMaterial();
289 #endif 289 #endif
(...skipping 32 matching lines...) Expand 10 before | Expand all | Expand 10 after
322 RemoveChildView(combobox_); 322 RemoveChildView(combobox_);
323 } 323 }
324 324
325 void PermissionSelectorRow::InitializeMenuButtonView( 325 void PermissionSelectorRow::InitializeMenuButtonView(
326 views::GridLayout* layout, 326 views::GridLayout* layout,
327 const WebsiteSettingsUI::PermissionInfo& permission) { 327 const WebsiteSettingsUI::PermissionInfo& permission) {
328 bool button_enabled = 328 bool button_enabled =
329 permission.source == content_settings::SETTING_SOURCE_USER; 329 permission.source == content_settings::SETTING_SOURCE_USER;
330 menu_button_ = new internal::PermissionMenuButton( 330 menu_button_ = new internal::PermissionMenuButton(
331 WebsiteSettingsUI::PermissionActionToUIString( 331 WebsiteSettingsUI::PermissionActionToUIString(
332 permission.type, permission.setting, permission.default_setting, 332 profile_, permission.type, permission.setting,
333 permission.source), 333 permission.default_setting, permission.source),
334 menu_model_.get(), button_enabled); 334 menu_model_.get(), button_enabled);
335 menu_button_->SetEnabled(button_enabled); 335 menu_button_->SetEnabled(button_enabled);
336 menu_button_->SetAccessibleName( 336 menu_button_->SetAccessibleName(
337 WebsiteSettingsUI::PermissionTypeToUIString(permission.type)); 337 WebsiteSettingsUI::PermissionTypeToUIString(permission.type));
338 layout->AddView(menu_button_); 338 layout->AddView(menu_button_);
339 } 339 }
340 340
341 void PermissionSelectorRow::InitializeComboboxView( 341 void PermissionSelectorRow::InitializeComboboxView(
342 views::GridLayout* layout, 342 views::GridLayout* layout,
343 const WebsiteSettingsUI::PermissionInfo& permission) { 343 const WebsiteSettingsUI::PermissionInfo& permission) {
344 bool button_enabled = 344 bool button_enabled =
345 permission.source == content_settings::SETTING_SOURCE_USER; 345 permission.source == content_settings::SETTING_SOURCE_USER;
346 combobox_model_adapter_.reset( 346 combobox_model_adapter_.reset(
347 new internal::ComboboxModelAdapter(menu_model_.get())); 347 new internal::ComboboxModelAdapter(menu_model_.get()));
348 combobox_ = new internal::PermissionCombobox( 348 combobox_ = new internal::PermissionCombobox(
349 WebsiteSettingsUI::PermissionActionToUIString( 349 WebsiteSettingsUI::PermissionActionToUIString(
350 permission.type, permission.setting, permission.default_setting, 350 profile_, permission.type, permission.setting,
351 permission.source), 351 permission.default_setting, permission.source),
352 combobox_model_adapter_.get(), button_enabled, 352 combobox_model_adapter_.get(), button_enabled, true);
353 true);
354 combobox_->SetEnabled(button_enabled); 353 combobox_->SetEnabled(button_enabled);
355 combobox_->SetAccessibleName( 354 combobox_->SetAccessibleName(
356 WebsiteSettingsUI::PermissionTypeToUIString(permission.type)); 355 WebsiteSettingsUI::PermissionTypeToUIString(permission.type));
357 layout->AddView(combobox_); 356 layout->AddView(combobox_);
358 } 357 }
359 358
360 void PermissionSelectorRow::PermissionChanged( 359 void PermissionSelectorRow::PermissionChanged(
361 const WebsiteSettingsUI::PermissionInfo& permission) { 360 const WebsiteSettingsUI::PermissionInfo& permission) {
362 // Change the permission icon to reflect the selected setting. 361 // Change the permission icon to reflect the selected setting.
363 const gfx::Image& image = WebsiteSettingsUI::GetPermissionIcon(permission); 362 const gfx::Image& image = WebsiteSettingsUI::GetPermissionIcon(permission);
364 icon_->SetImage(image.ToImageSkia()); 363 icon_->SetImage(image.ToImageSkia());
365 364
366 // Update the menu button text to reflect the new setting. 365 // Update the menu button text to reflect the new setting.
367 if (menu_button_) { 366 if (menu_button_) {
368 menu_button_->SetText(WebsiteSettingsUI::PermissionActionToUIString( 367 menu_button_->SetText(WebsiteSettingsUI::PermissionActionToUIString(
369 permission.type, permission.setting, permission.default_setting, 368 profile_, permission.type, permission.setting,
370 content_settings::SETTING_SOURCE_USER)); 369 permission.default_setting, content_settings::SETTING_SOURCE_USER));
371 menu_button_->SizeToPreferredSize(); 370 menu_button_->SizeToPreferredSize();
372 } else if (combobox_) { 371 } else if (combobox_) {
373 bool use_default = permission.setting == CONTENT_SETTING_DEFAULT; 372 bool use_default = permission.setting == CONTENT_SETTING_DEFAULT;
374 combobox_->UpdateSelectedIndex(use_default); 373 combobox_->UpdateSelectedIndex(use_default);
375 } 374 }
376 375
377 FOR_EACH_OBSERVER(PermissionSelectorRowObserver, 376 FOR_EACH_OBSERVER(PermissionSelectorRowObserver,
378 observer_list_, 377 observer_list_,
379 OnPermissionChanged(permission)); 378 OnPermissionChanged(permission));
380 } 379 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698