Teach valgrind about the new storage_unittests target.

Teach valgrind about the new storage_unittests target.

BUG=653751
Committed: https://crrev.com/8a4a2b4bf5c64772dcc8f9e20b779ee621b3b035
Cr-Commit-Position: refs/heads/master@{#424408}

[pwnall, 2016-10-08 00:24:17]

The CQ bit was checked by pwnall@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-08 00:24:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-08 01:29:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-08 01:29:11]

Dry run: This issue passed the CQ dry run.

[pwnall, 2016-10-11 03:09:18]

pwnall@chromium.org changed reviewers:
+ thakis@chromium.org

[pwnall, 2016-10-11 03:09:19]

PTAL?

[Alexander Potapenko, 2016-10-11 09:21:30]

On 2016/10/11 03:09:19, pwnall wrote:
> PTAL?

Do you actually use Valgrind for testing?
We've removed it from the waterfalls quite a while ago.

[Alexander Potapenko, 2016-10-11 09:24:09]

On 2016/10/11 09:21:30, Alexander Potapenko wrote:
> On 2016/10/11 03:09:19, pwnall wrote:
> > PTAL?
> 
> Do you actually use Valgrind for testing?
> We've removed it from the waterfalls quite a while ago.

I don't object against this particular CL, but be prepared that Valgrind is
going to rot sooner or later and will be totally removed from Chromium at some
point.

[pwnall, 2016-10-11 09:33:57]

On 2016/10/11 09:24:09, Alexander Potapenko wrote:
> On 2016/10/11 09:21:30, Alexander Potapenko wrote:
> > On 2016/10/11 03:09:19, pwnall wrote:
> > > PTAL?
> > 
> > Do you actually use Valgrind for testing?
> > We've removed it from the waterfalls quite a while ago.
> 
> I don't object against this particular CL, but be prepared that Valgrind is
> going to rot sooner or later and will be totally removed from Chromium at some
> point.

I was just adding storage_unittests in all the places where content_unittests
shows up, as I'll be moving some tests from content_unittests into
storage_unittests. This valgrind-related script is one of those places.

It seems to me that updating this file can't hurt, so can we please do it? :D If
it gets removed eventually, this CL won't do any damage. If it is resurrected,
for some reason, this CL will make sure that the storage tests are in the same
shape as all the other tests.

[Alexander Potapenko, 2016-10-11 09:49:02]

Sure, LGTM

[Alexander Potapenko, 2016-10-11 09:49:02]

Sure, LGTM

[Alexander Potapenko, 2016-10-11 12:08:17]

The CQ bit was checked by glider@chromium.org

[commit-bot: I haz the power, 2016-10-11 12:08:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-11 12:18:52]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-10-11 12:20:56]

Description was changed from

==========
Teach valgrind about the new storage_unittests target.

BUG=653751
==========

to

==========
Teach valgrind about the new storage_unittests target.

BUG=653751

Committed: https://crrev.com/8a4a2b4bf5c64772dcc8f9e20b779ee621b3b035
Cr-Commit-Position: refs/heads/master@{#424408}
==========

[commit-bot: I haz the power, 2016-10-11 12:20:57]

Patchset 1 (id:??) landed as
https://crrev.com/8a4a2b4bf5c64772dcc8f9e20b779ee621b3b035
Cr-Commit-Position: refs/heads/master@{#424408}