Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issue 2408553002: Teach valgrind about the new storage_unittests target. (Closed)

Created:
4 years, 2 months ago by pwnall
Modified:
4 years, 2 months ago
CC:
chromium-reviews, glider+watch_chromium.org, bruening+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Teach valgrind about the new storage_unittests target. BUG=653751 Committed: https://crrev.com/8a4a2b4bf5c64772dcc8f9e20b779ee621b3b035 Cr-Commit-Position: refs/heads/master@{#424408}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M tools/valgrind/chrome_tests.py View 2 chunks +4 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 16 (7 generated)
pwnall
PTAL?
4 years, 2 months ago (2016-10-11 03:09:19 UTC) #6
Alexander Potapenko
On 2016/10/11 03:09:19, pwnall wrote: > PTAL? Do you actually use Valgrind for testing? We've ...
4 years, 2 months ago (2016-10-11 09:21:30 UTC) #7
Alexander Potapenko
On 2016/10/11 09:21:30, Alexander Potapenko wrote: > On 2016/10/11 03:09:19, pwnall wrote: > > PTAL? ...
4 years, 2 months ago (2016-10-11 09:24:09 UTC) #8
pwnall
On 2016/10/11 09:24:09, Alexander Potapenko wrote: > On 2016/10/11 09:21:30, Alexander Potapenko wrote: > > ...
4 years, 2 months ago (2016-10-11 09:33:57 UTC) #9
Alexander Potapenko
Sure, LGTM
4 years, 2 months ago (2016-10-11 09:49:02 UTC) #10
Alexander Potapenko
Sure, LGTM
4 years, 2 months ago (2016-10-11 09:49:02 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2408553002/1
4 years, 2 months ago (2016-10-11 12:08:29 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-11 12:18:52 UTC) #14
commit-bot: I haz the power
4 years, 2 months ago (2016-10-11 12:20:57 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8a4a2b4bf5c64772dcc8f9e20b779ee621b3b035
Cr-Commit-Position: refs/heads/master@{#424408}

Powered by Google App Engine
This is Rietveld 408576698