Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Issue 2402593002: Create storage_unittests target. (Closed)

Created:
4 years, 2 months ago by pwnall
Modified:
4 years, 2 months ago
Reviewers:
michaeln
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Create storage_unittests target. storage_unittests will eventually host the tests for files in storage/ that now live under content/browser/ so they can be included in the content_unittests target. Follow up CLs will add storage_unittests to trybots and waterfalls and, eventually, move the relevant tests from content/browser/ to storage/ BUG=653751 Committed: https://crrev.com/38a061e08ece1f0894e7489afac24d47db964e4a Cr-Commit-Position: refs/heads/master@{#424324}

Patch Set 1 #

Patch Set 2 : Attempt to appease win_clang. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -0 lines) Patch
M storage/browser/BUILD.gn View 1 2 chunks +19 lines, -0 lines 0 comments Download
A storage/browser/crbug653751_unittest.cc View 1 1 chunk +13 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 18 (12 generated)
pwnall
PTAL?
4 years, 2 months ago (2016-10-08 02:00:03 UTC) #11
michaeln
lgtm
4 years, 2 months ago (2016-10-11 00:19:10 UTC) #12
pwnall
On 2016/10/11 00:19:10, michaeln wrote: > lgtm Thank you very much!
4 years, 2 months ago (2016-10-11 00:23:28 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2402593002/40001
4 years, 2 months ago (2016-10-11 00:23:40 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 2 months ago (2016-10-11 01:19:58 UTC) #16
commit-bot: I haz the power
4 years, 2 months ago (2016-10-11 01:25:08 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/38a061e08ece1f0894e7489afac24d47db964e4a
Cr-Commit-Position: refs/heads/master@{#424324}

Powered by Google App Engine
This is Rietveld 408576698