Issue 24085002: Correctly apply per-keyframe timing functions

Issue 24085002: Correctly apply per-keyframe timing functions (Closed)

Created:
7 years, 3 months ago by Steve Block

Modified:
7 years ago

Reviewers:
dstockwell

CC:
blink-reviews, shans, rjwright, alancutter (OOO until 2018), Mike Lawther (Google), eae+blinkwatch, dglazkov+blink, dstockwell, Timothy Loh, darktears, Steve Block, dino_apple.com, Eric Willigers

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Correctly apply per-keyframe timing functions Currently, when a per-keyframe timing function is applied to an element which is targeted by multiple animations, the timing function may be applied to the wrong CSSAnimationData object. This causes the per-keyframe timing function to be ignored. This patch fixes the problem by making sure the relevant CSSAnimationData object is always first in the keyframe's RenderStyle. R=dstockwell BUG=288540, 322680 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=162672

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+153 lines, -24 lines)			Patch
A	LayoutTests/animations/animation-properties-in-keyframe-are-ignored.html	View	1 2 3 4	1 chunk	+60 lines, -0 lines	0 comments	Download
A	LayoutTests/animations/animation-properties-in-keyframe-are-ignored-expected.txt	View	1 2 3 4	1 chunk	+7 lines, -0 lines	0 comments	Download
A	LayoutTests/animations/keyframe-timing-functions-multiple-animations.html	View	1	1 chunk	+52 lines, -0 lines	0 comments	Download
A	LayoutTests/animations/keyframe-timing-functions-multiple-animations-expected.txt	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download
M	Source/core/animation/css/CSSAnimations.cpp	View	1	2 chunks	+4 lines, -6 lines	0 comments	Download
M	Source/core/css/resolver/StyleResolver.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/css/resolver/StyleResolver.cpp	View	1 2 3 4 5	5 chunks	+17 lines, -4 lines	0 comments	Download
M	Source/core/frame/animation/KeyframeAnimation.cpp	View	1	1 chunk	+1 line, -3 lines	0 comments	Download
M	Source/core/rendering/animation/WebAnimationProvider.cpp	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/rendering/style/KeyframeList.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/rendering/style/KeyframeList.cpp	View	1 2	1 chunk	+4 lines, -8 lines	0 comments	Download