[Extensions] Convert some ChromeSyncExtensionFunctions

[Extensions] Convert some ChromeSyncExtensionFunctions

SyncExtensionFunctions, AsyncExtensionFunctions,
ChromeSyncExtensionFunctions, and ChromeAsyncExtensionFunctions are
deprecated.

Remove ChromeSyncExtensionFunctions from:
- extension_action
- file_system_provider

BUG=634140
Committed: https://crrev.com/2ef2539bb09e6e73fb0850be03ad5a38658b6f4d
Cr-Commit-Position: refs/heads/master@{#424168}

[Devlin, 2016-10-07 21:26:31]

The CQ bit was checked by rdevlin.cronin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-07 21:26:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-07 22:13:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-07 22:13:09]

Dry run: This issue passed the CQ dry run.

[Devlin, 2016-10-07 23:09:54]

rdevlin.cronin@chromium.org changed reviewers:
+ lazyboy@chromium.org

[Devlin, 2016-10-07 23:09:55]

Istiaque, can you take a quick look?

[lazyboy, 2016-10-07 23:32:51]

lgtm

https://codereview.chromium.org/2408483002/diff/1/chrome/browser/extensions/a...
File chrome/browser/extensions/api/extension_action/extension_action_api.cc
(right):

https://codereview.chromium.org/2408483002/diff/1/chrome/browser/extensions/a...
chrome/browser/extensions/api/extension_action/extension_action_api.cc:427:
SetVisible(true);
maybe change SetVisible to return void?

[Devlin, 2016-10-10 15:32:56]

The CQ bit was checked by rdevlin.cronin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-10 15:33:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-10 16:20:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-10 16:20:19]

Dry run: This issue passed the CQ dry run.

[Devlin, 2016-10-10 16:29:01]

https://codereview.chromium.org/2408483002/diff/1/chrome/browser/extensions/a...
File chrome/browser/extensions/api/extension_action/extension_action_api.cc
(right):

https://codereview.chromium.org/2408483002/diff/1/chrome/browser/extensions/a...
chrome/browser/extensions/api/extension_action/extension_action_api.cc:427:
SetVisible(true);
On 2016/10/07 23:32:51, lazyboy wrote:
> maybe change SetVisible to return void?

Good call, done.

[Devlin, 2016-10-10 16:29:05]

The CQ bit was checked by rdevlin.cronin@chromium.org

[Devlin, 2016-10-10 16:29:05]

The patchset sent to the CQ was uploaded after l-g-t-m from lazyboy@chromium.org
Link to the patchset: https://codereview.chromium.org/2408483002/#ps20001
(title: "lazyboy's")

[commit-bot: I haz the power, 2016-10-10 16:29:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-10 16:34:44]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-10 16:37:20]

Description was changed from

==========
[Extensions] Convert some ChromeSyncExtensionFunctions

SyncExtensionFunctions, AsyncExtensionFunctions,
ChromeSyncExtensionFunctions, and ChromeAsyncExtensionFunctions are
deprecated.

Remove ChromeSyncExtensionFunctions from:
- extension_action
- file_system_provider

BUG=634140
==========

to

==========
[Extensions] Convert some ChromeSyncExtensionFunctions

SyncExtensionFunctions, AsyncExtensionFunctions,
ChromeSyncExtensionFunctions, and ChromeAsyncExtensionFunctions are
deprecated.

Remove ChromeSyncExtensionFunctions from:
- extension_action
- file_system_provider

BUG=634140

Committed: https://crrev.com/2ef2539bb09e6e73fb0850be03ad5a38658b6f4d
Cr-Commit-Position: refs/heads/master@{#424168}
==========

[commit-bot: I haz the power, 2016-10-10 16:37:21]

Patchset 2 (id:??) landed as
https://crrev.com/2ef2539bb09e6e73fb0850be03ad5a38658b6f4d
Cr-Commit-Position: refs/heads/master@{#424168}