Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Issue 2408483002: [Extensions] Convert some ChromeSyncExtensionFunctions (Closed)

Created:
4 years, 2 months ago by Devlin
Modified:
4 years, 2 months ago
Reviewers:
lazyboy
CC:
chromium-reviews, extensions-reviews_chromium.org, yamaguchi+watch_chromium.org, oka+watch_chromium.org, oshima+watch_chromium.org, fukino+watch_chromium.org, chromium-apps-reviews_chromium.org, davemoore+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Extensions] Convert some ChromeSyncExtensionFunctions SyncExtensionFunctions, AsyncExtensionFunctions, ChromeSyncExtensionFunctions, and ChromeAsyncExtensionFunctions are deprecated. Remove ChromeSyncExtensionFunctions from: - extension_action - file_system_provider BUG=634140 Committed: https://crrev.com/2ef2539bb09e6e73fb0850be03ad5a38658b6f4d Cr-Commit-Position: refs/heads/master@{#424168}

Patch Set 1 #

Total comments: 2

Patch Set 2 : lazyboy's #

Messages

Total messages: 18 (12 generated)
Devlin
Istiaque, can you take a quick look?
4 years, 2 months ago (2016-10-07 23:09:55 UTC) #6
lazyboy
lgtm https://codereview.chromium.org/2408483002/diff/1/chrome/browser/extensions/api/extension_action/extension_action_api.cc File chrome/browser/extensions/api/extension_action/extension_action_api.cc (right): https://codereview.chromium.org/2408483002/diff/1/chrome/browser/extensions/api/extension_action/extension_action_api.cc#newcode427 chrome/browser/extensions/api/extension_action/extension_action_api.cc:427: SetVisible(true); maybe change SetVisible to return void?
4 years, 2 months ago (2016-10-07 23:32:51 UTC) #7
Devlin
https://codereview.chromium.org/2408483002/diff/1/chrome/browser/extensions/api/extension_action/extension_action_api.cc File chrome/browser/extensions/api/extension_action/extension_action_api.cc (right): https://codereview.chromium.org/2408483002/diff/1/chrome/browser/extensions/api/extension_action/extension_action_api.cc#newcode427 chrome/browser/extensions/api/extension_action/extension_action_api.cc:427: SetVisible(true); On 2016/10/07 23:32:51, lazyboy wrote: > maybe change ...
4 years, 2 months ago (2016-10-10 16:29:01 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2408483002/20001
4 years, 2 months ago (2016-10-10 16:29:13 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-10 16:34:44 UTC) #16
commit-bot: I haz the power
4 years, 2 months ago (2016-10-10 16:37:21 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2ef2539bb09e6e73fb0850be03ad5a38658b6f4d
Cr-Commit-Position: refs/heads/master@{#424168}

Powered by Google App Engine
This is Rietveld 408576698