Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3156)

Unified Diff: chrome/browser/chromeos/extensions/file_system_provider/provider_function.h

Issue 2408483002: [Extensions] Convert some ChromeSyncExtensionFunctions (Closed)
Patch Set: lazyboy's Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/extensions/file_system_provider/provider_function.h
diff --git a/chrome/browser/chromeos/extensions/file_system_provider/provider_function.h b/chrome/browser/chromeos/extensions/file_system_provider/provider_function.h
index b297f1bbb682982e42f265412838af93eccd5ade..19c9e5a38b5665fc095ee83c3f09d3a00ba0f67f 100644
--- a/chrome/browser/chromeos/extensions/file_system_provider/provider_function.h
+++ b/chrome/browser/chromeos/extensions/file_system_provider/provider_function.h
@@ -50,39 +50,29 @@ base::File::Error ProviderErrorToFileError(
// Base class for internal API functions handling request results, either
// a success or a failure.
-class FileSystemProviderInternalFunction : public ChromeSyncExtensionFunction {
+class FileSystemProviderInternalFunction : public UIThreadExtensionFunction {
public:
FileSystemProviderInternalFunction();
protected:
~FileSystemProviderInternalFunction() override {}
- // Rejects the request and sets a response for this API function. Returns true
- // on success, and false on failure.
- bool RejectRequest(
+ // Rejects the request and returns a response for this API function.
+ ResponseAction RejectRequest(
std::unique_ptr<chromeos::file_system_provider::RequestValue> value,
base::File::Error error);
// Fulfills the request with parsed arguments of this API function
- // encapsulated as a RequestValue instance. Also, sets a response.
+ // encapsulated as a RequestValue instance and returns a response.
// If |has_more| is set to true, then the function will be called again for
- // this request. Returns true on success, and false on failure.
- bool FulfillRequest(
+ // this request.
+ ResponseAction FulfillRequest(
std::unique_ptr<chromeos::file_system_provider::RequestValue> value,
bool has_more);
- // Subclasses implement this for their functionality.
- // Called after Parse() is successful, such that |request_id_| and
- // |request_manager_| have been fully initialized.
- virtual bool RunWhenValid() = 0;
-
- // ChromeSyncExtensionFunction overrides.
- bool RunSync() override;
-
private:
- // Parses the request in order to extract the request manager. If fails, then
- // sets a response and returns false.
- bool Parse();
+ // Guarantees |request_id_| and |request_manager_| are valid.
+ bool PreRunValidation(std::string* error) override;
int request_id_;
chromeos::file_system_provider::RequestManager* request_manager_;

Powered by Google App Engine
This is Rietveld 408576698