[Sync] Move network-related code from core/ to engine/net/.

[Sync] Move network-related code from core/ to engine/net/.

Everything is being moved out of core/ to better places.

engine/net/
  http_bridge
  http_bridge_network_resources
  http_post_provider_factory
  http_post_provider_interface
  network_resources
  network_time_update_callback

engine_impl/net/
  syncapi_server_connection_manager -> server_connection_manager_impl

BUG=631271
Committed: https://crrev.com/f0ab40f5b918737b09312cd19a337ddb20edc1be
Cr-Commit-Position: refs/heads/master@{#424445}

[maxbogue, 2016-10-07 20:50:36]

The CQ bit was checked by maxbogue@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-07 20:51:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[maxbogue, 2016-10-07 20:54:58]

maxbogue@chromium.org changed reviewers:
+ pavely@chromium.org

[maxbogue, 2016-10-07 20:54:58]

Pavel, PTAL!

[commit-bot: I haz the power, 2016-10-07 21:46:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-07 21:46:13]

Dry run: This issue passed the CQ dry run.

[maxbogue, 2016-10-10 04:57:57]

The CQ bit was checked by maxbogue@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-10 04:58:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[maxbogue, 2016-10-10 04:59:07]

Description was changed from

==========
[Sync] Move network-related code from core/ to engine/net/.

Everything is being moved out of core/ to better places.

engine/net/
  http_bridge
  http_bridge_network_resources
  http_post_provider_factory
  http_post_provider_interface
  network_resources
  network_time_update_callback

engine_impl/net/
  syncapi_server_connection_manager

BUG=631271
==========

to

==========
[Sync] Move network-related code from core/ to engine/net/.

Everything is being moved out of core/ to better places.

engine/net/
  http_bridge
  http_bridge_network_resources
  http_post_provider_factory
  http_post_provider_interface
  network_resources
  network_time_update_callback

engine_impl/net/
  syncapi_server_connection_manager -> server_connection_manager_impl

BUG=631271
==========

[commit-bot: I haz the power, 2016-10-10 05:48:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-10 05:48:38]

Dry run: This issue passed the CQ dry run.

[pavely, 2016-10-10 18:54:06]

https://codereview.chromium.org/2408463002/diff/20001/components/sync/engine_...
File components/sync/engine_impl/net/server_connection_manager_impl.h (right):

https://codereview.chromium.org/2408463002/diff/20001/components/sync/engine_...
components/sync/engine_impl/net/server_connection_manager_impl.h:49: class
ServerConnectionManagerImpl : public ServerConnectionManager {
Usually class is named Impl if base class is an interface and this class is
implementation. In this case ServerConnectionManager is an implementation and
this class is a specialization of how it interacts with network.
I think this class shouldn't be renamed to Impl.

[maxbogue, 2016-10-10 19:49:07]

The CQ bit was checked by maxbogue@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-10 19:49:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[maxbogue, 2016-10-10 20:36:48]

https://codereview.chromium.org/2408463002/diff/20001/components/sync/engine_...
File components/sync/engine_impl/net/server_connection_manager_impl.h (right):

https://codereview.chromium.org/2408463002/diff/20001/components/sync/engine_...
components/sync/engine_impl/net/server_connection_manager_impl.h:49: class
ServerConnectionManagerImpl : public ServerConnectionManager {
On 2016/10/10 18:54:06, pavely wrote:
> Usually class is named Impl if base class is an interface and this class is
> implementation. In this case ServerConnectionManager is an implementation and
> this class is a specialization of how it interacts with network.
> I think this class shouldn't be renamed to Impl.

Switched to SyncServerConnectionManager instead, PTAL!

[commit-bot: I haz the power, 2016-10-10 21:44:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-10 21:44:36]

Dry run: This issue passed the CQ dry run.

[pavely, 2016-10-10 23:14:57]

lgtm

[maxbogue, 2016-10-11 15:03:13]

The CQ bit was checked by maxbogue@chromium.org

[commit-bot: I haz the power, 2016-10-11 15:03:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-11 15:13:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-11 15:13:25]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[maxbogue, 2016-10-11 15:17:44]

maxbogue@chromium.org changed reviewers:
+ davidben@chromium.org

[maxbogue, 2016-10-11 15:17:45]

+davidben for //net DEPS. This CL just moves files to a new location.

[davidben, 2016-10-11 16:04:15]

On 2016/10/11 15:17:45, maxbogue wrote:
> +davidben for //net DEPS. This CL just moves files to a new location.

lgtm. I gather the intent is that sync/core doesn't depend on //net? In that
case, should there be a removal of the other DEPS entry too?

[maxbogue, 2016-10-11 16:05:48]

The CQ bit was checked by maxbogue@chromium.org

[commit-bot: I haz the power, 2016-10-11 16:06:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[maxbogue, 2016-10-11 16:06:40]

On 2016/10/11 16:04:15, davidben wrote:
> On 2016/10/11 15:17:45, maxbogue wrote:
> > +davidben for //net DEPS. This CL just moves files to a new location.
> 
> lgtm. I gather the intent is that sync/core doesn't depend on //net? In that
> case, should there be a removal of the other DEPS entry too?

The intent is to remove sync/core entirely, so it will go away soon regardless
:)

[commit-bot: I haz the power, 2016-10-11 16:13:05]

Description was changed from

==========
[Sync] Move network-related code from core/ to engine/net/.

Everything is being moved out of core/ to better places.

engine/net/
  http_bridge
  http_bridge_network_resources
  http_post_provider_factory
  http_post_provider_interface
  network_resources
  network_time_update_callback

engine_impl/net/
  syncapi_server_connection_manager -> server_connection_manager_impl

BUG=631271
==========

to

==========
[Sync] Move network-related code from core/ to engine/net/.

Everything is being moved out of core/ to better places.

engine/net/
  http_bridge
  http_bridge_network_resources
  http_post_provider_factory
  http_post_provider_interface
  network_resources
  network_time_update_callback

engine_impl/net/
  syncapi_server_connection_manager -> server_connection_manager_impl

BUG=631271
==========

[commit-bot: I haz the power, 2016-10-11 16:13:07]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-10-11 16:15:47]

Description was changed from

==========
[Sync] Move network-related code from core/ to engine/net/.

Everything is being moved out of core/ to better places.

engine/net/
  http_bridge
  http_bridge_network_resources
  http_post_provider_factory
  http_post_provider_interface
  network_resources
  network_time_update_callback

engine_impl/net/
  syncapi_server_connection_manager -> server_connection_manager_impl

BUG=631271
==========

to

==========
[Sync] Move network-related code from core/ to engine/net/.

Everything is being moved out of core/ to better places.

engine/net/
  http_bridge
  http_bridge_network_resources
  http_post_provider_factory
  http_post_provider_interface
  network_resources
  network_time_update_callback

engine_impl/net/
  syncapi_server_connection_manager -> server_connection_manager_impl

BUG=631271

Committed: https://crrev.com/f0ab40f5b918737b09312cd19a337ddb20edc1be
Cr-Commit-Position: refs/heads/master@{#424445}
==========

[commit-bot: I haz the power, 2016-10-11 16:15:48]

Patchset 3 (id:??) landed as
https://crrev.com/f0ab40f5b918737b09312cd19a337ddb20edc1be
Cr-Commit-Position: refs/heads/master@{#424445}