Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(612)

Unified Diff: components/sync/engine_impl/net/sync_server_connection_manager.h

Issue 2408463002: [Sync] Move network-related code from core/ to engine/net/. (Closed)
Patch Set: Use SyncServerConnectionManager instead of ServerConnectionManagerImpl. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/sync/engine_impl/net/sync_server_connection_manager.h
diff --git a/components/sync/engine_impl/net/sync_server_connection_manager.h b/components/sync/engine_impl/net/sync_server_connection_manager.h
new file mode 100644
index 0000000000000000000000000000000000000000..f9b03c065ce289f9a380c2feca22e64e0f55bb94
--- /dev/null
+++ b/components/sync/engine_impl/net/sync_server_connection_manager.h
@@ -0,0 +1,78 @@
+// Copyright 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef COMPONENTS_SYNC_ENGINE_IMPL_NET_SYNC_SERVER_CONNECTION_MANAGER_H_
+#define COMPONENTS_SYNC_ENGINE_IMPL_NET_SYNC_SERVER_CONNECTION_MANAGER_H_
+
+#include <memory>
+#include <string>
+
+#include "base/compiler_specific.h"
+#include "base/gtest_prod_util.h"
+#include "base/macros.h"
+#include "components/sync/engine_impl/net/server_connection_manager.h"
+
+namespace syncer {
+
+class HttpPostProviderFactory;
+class HttpPostProviderInterface;
+
+// This provides HTTP Post functionality through the interface provided
+// by the application hosting the syncer backend.
+class SyncBridgedConnection : public ServerConnectionManager::Connection {
+ public:
+ SyncBridgedConnection(ServerConnectionManager* scm,
+ HttpPostProviderFactory* factory);
+
+ ~SyncBridgedConnection() override;
+
+ bool Init(const char* path,
+ const std::string& auth_token,
+ const std::string& payload,
+ HttpResponse* response) override;
+
+ void Abort() override;
+
+ private:
+ // Pointer to the factory we use for creating HttpPostProviders. We do not
+ // own |factory_|.
+ HttpPostProviderFactory* factory_;
+
+ HttpPostProviderInterface* post_provider_;
+
+ DISALLOW_COPY_AND_ASSIGN(SyncBridgedConnection);
+};
+
+// A ServerConnectionManager subclass that generates a POST object using an
+// instance of the HttpPostProviderFactory class.
+class SyncServerConnectionManager : public ServerConnectionManager {
+ public:
+ // Takes ownership of factory.
+ SyncServerConnectionManager(const std::string& server,
+ int port,
+ bool use_ssl,
+ HttpPostProviderFactory* factory,
+ CancelationSignal* cancelation_signal);
+ ~SyncServerConnectionManager() override;
+
+ // ServerConnectionManager overrides.
+ Connection* MakeConnection() override;
+
+ private:
+ FRIEND_TEST_ALL_PREFIXES(SyncServerConnectionManagerTest, VeryEarlyAbortPost);
+ FRIEND_TEST_ALL_PREFIXES(SyncServerConnectionManagerTest, EarlyAbortPost);
+ FRIEND_TEST_ALL_PREFIXES(SyncServerConnectionManagerTest, AbortPost);
+ FRIEND_TEST_ALL_PREFIXES(SyncServerConnectionManagerTest,
+ FailPostWithTimedOut);
+
+ // A factory creating concrete HttpPostProviders for use whenever we need to
+ // issue a POST to sync servers.
+ std::unique_ptr<HttpPostProviderFactory> post_provider_factory_;
+
+ DISALLOW_COPY_AND_ASSIGN(SyncServerConnectionManager);
+};
+
+} // namespace syncer
+
+#endif // COMPONENTS_SYNC_ENGINE_IMPL_NET_SYNC_SERVER_CONNECTION_MANAGER_H_

Powered by Google App Engine
This is Rietveld 408576698