Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issue 2408343002: Update DesktopCanvas to allow over-panning when Soft Input Method is present. (Closed)

Created:
4 years, 2 months ago by joedow
Modified:
4 years, 2 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2883
Project:
chromium
Visibility:
Public.

Description

Update DesktopCanvas to allow over-panning when Soft Input Method is present. My previous change allowed the user to 'over-pan' the desktop image such that it can be pulled out from under any System UI present. After using the feature a bit and tqalking with other folks on the team, I think this behavior should be restricted to only be allowed when a Soft Input Method is present. BUG=654565 Review-Url: https://codereview.chromium.org/2411503002 Cr-Commit-Position: refs/heads/master@{#424506} (cherry picked from commit 99f909132e4756059b6414b723beadd72453a71c) Committed: https://chromium.googlesource.com/chromium/src/+/65c8ec0c0d3d8d3c79096a2bba6ae3b80da2d951

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M remoting/android/java/src/org/chromium/chromoting/DesktopCanvas.java View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
joedow
4 years, 2 months ago (2016-10-11 22:51:21 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
65c8ec0c0d3d8d3c79096a2bba6ae3b80da2d951.

Powered by Google App Engine
This is Rietveld 408576698