third_party/WebKit/Source/web/WebLocalFrameImpl.cpp - Issue 2408333004: Move persistent gesture state to Document, add DocumentUserGestureToken

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/WebLocalFrameImpl.cpp

Issue 2408333004: Move persistent gesture state to Document, add DocumentUserGestureToken (Closed)

Patch Set: Re-add dropped null check Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/web/WebLocalFrameImpl.cpp

diff --git a/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp b/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp

index c0dffe073239c9626bb6734bdbde53eb45c11eaa..0b5db4345b09c172ed0ced603228f3cc9fae5721 100644

--- a/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp

+++ b/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp

@@ -100,6 +100,7 @@

#include "bindings/core/v8/V8PerIsolateData.h"

#include "core/HTMLNames.h"

#include "core/dom/Document.h"

+#include "core/dom/DocumentUserGestureToken.h"

#include "core/dom/IconURL.h"

#include "core/dom/MessagePort.h"

#include "core/dom/Node.h"

@@ -1900,8 +1901,8 @@ void WebLocalFrameImpl::loadJavaScriptURL(const KURL& url) {

String script = decodeURLEscapeSequences(

url.getString().substring(strlen("javascript:")));

- UserGestureIndicator gestureIndicator(

- UserGestureToken::create(UserGestureToken::NewGesture));

+ UserGestureIndicator gestureIndicator(DocumentUserGestureToken::create(

+ frame()->document(), UserGestureToken::NewGesture));

v8::HandleScope handleScope(toIsolate(frame()));

v8::Local<v8::Value> result =

frame()->script().executeScriptInMainWorldAndReturnValue(