third_party/WebKit/Source/web/WebPluginContainerImpl.cpp - Issue 2408333004: Move persistent gesture state to Document, add DocumentUserGestureToken

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/WebPluginContainerImpl.cpp

Issue 2408333004: Move persistent gesture state to Document, add DocumentUserGestureToken (Closed)

Patch Set: Re-add dropped null check Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/web/WebPluginContainerImpl.cpp

diff --git a/third_party/WebKit/Source/web/WebPluginContainerImpl.cpp b/third_party/WebKit/Source/web/WebPluginContainerImpl.cpp

index c707176efa44bd75fe781176e642adca162f59a5..99e6289e54bbce2a714e96c539ca762e1345ea33 100644

--- a/third_party/WebKit/Source/web/WebPluginContainerImpl.cpp

+++ b/third_party/WebKit/Source/web/WebPluginContainerImpl.cpp

@@ -37,6 +37,7 @@

#include "core/HTMLNames.h"

#include "core/clipboard/DataObject.h"

#include "core/clipboard/DataTransfer.h"

+#include "core/dom/DocumentUserGestureToken.h"

#include "core/dom/ExecutionContext.h"

#include "core/dom/Fullscreen.h"

#include "core/events/DragEvent.h"

@@ -478,7 +479,8 @@ WebString WebPluginContainerImpl::executeScriptURL(const WebURL& url,

kurl.getString().substring(strlen("javascript:")));

UserGestureIndicator gestureIndicator(

- popupsAllowed ? UserGestureToken::create(UserGestureToken::NewGesture)

+ popupsAllowed ? DocumentUserGestureToken::create(

+ frame->document(), UserGestureToken::NewGesture)

: nullptr);

v8::HandleScope handleScope(toIsolate(frame));

v8::Local<v8::Value> result =