extensions/renderer/messaging_bindings.cc - Issue 2408333004: Move persistent gesture state to Document, add DocumentUserGestureToken

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/renderer/messaging_bindings.cc

Issue 2408333004: Move persistent gesture state to Document, add DocumentUserGestureToken (Closed)

Patch Set: Re-add dropped null check Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/renderer/messaging_bindings.cc

diff --git a/extensions/renderer/messaging_bindings.cc b/extensions/renderer/messaging_bindings.cc

index b9f20ff69b6736f5a4c449744d4f48904239ce1d..5462e373229570e937a4b95a9b87d92e86d718ec 100644

--- a/extensions/renderer/messaging_bindings.cc

+++ b/extensions/renderer/messaging_bindings.cc

@@ -203,7 +203,8 @@ void DeliverMessageToScriptContext(const Message& message,

std::unique_ptr<blink::WebScopedWindowFocusAllowedIndicator>

allow_window_focus;

if (message.user_gesture) {

- web_user_gesture.reset(new blink::WebScopedUserGesture);

+ web_user_gesture.reset(

+ new blink::WebScopedUserGesture(script_context->web_frame()));

if (script_context->web_frame()) {

blink::WebDocument document = script_context->web_frame()->document();