extensions/renderer/guest_view/guest_view_internal_custom_bindings.cc - Issue 2408333004: Move persistent gesture state to Document, add DocumentUserGestureToken

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/renderer/guest_view/guest_view_internal_custom_bindings.cc

Issue 2408333004: Move persistent gesture state to Document, add DocumentUserGestureToken (Closed)

Patch Set: Re-add dropped null check Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: extensions/renderer/guest_view/guest_view_internal_custom_bindings.cc

diff --git a/extensions/renderer/guest_view/guest_view_internal_custom_bindings.cc b/extensions/renderer/guest_view/guest_view_internal_custom_bindings.cc

index 060573ee1ca52f5cbe8d4729e37f541a80e3cf0d..021636e1d5dfbde01bc6ec4cfad54a96743cc05a 100644

--- a/extensions/renderer/guest_view/guest_view_internal_custom_bindings.cc

+++ b/extensions/renderer/guest_view/guest_view_internal_custom_bindings.cc

@@ -427,7 +427,7 @@ void GuestViewInternalCustomBindings::RegisterView(

void GuestViewInternalCustomBindings::RunWithGesture(

const v8::FunctionCallbackInfo<v8::Value>& args) {

// Gesture is required to request fullscreen.

- blink::WebScopedUserGesture user_gesture;

+ blink::WebScopedUserGesture user_gesture(context()->web_frame());

CHECK_EQ(args.Length(), 1);

CHECK(args[0]->IsFunction());

v8::Local<v8::Value> no_args;

« no previous file with comments | « extensions/renderer/dispatcher.cc ('k') | extensions/renderer/messaging_bindings.cc » ('j') | no next file with comments »