mash: Port TrayUpdateTest to AshTest

mash: Port TrayUpdateTest to AshTest

* Add AshTest::GetPrimarySystemTray().
* Set a TestSystemTrayDelegate in mash unittests because this test relies on
there not being an update available at test start, but SystemTrayDelegateMus
is based on DefaultSystemTrayDelegate, which simulates an update being ready.

BUG=654495
TEST=ash_unittests, mash_unittests

Committed: https://crrev.com/9d7d8eafd909e356d87b94e3fd2fc7e3d7d78aec
Cr-Commit-Position: refs/heads/master@{#424822}

[James Cook, 2016-10-11 19:57:32]

The CQ bit was checked by jamescook@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-11 19:58:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[James Cook, 2016-10-11 19:58:37]

jamescook@chromium.org changed reviewers:
+ sky@chromium.org

[James Cook, 2016-10-11 19:58:37]

sky, please take a look.

https://codereview.chromium.org/2408273002/diff/1/ash/common/wm_shell.h
File ash/common/wm_shell.h (right):

https://codereview.chromium.org/2408273002/diff/1/ash/common/wm_shell.h#newco...
ash/common/wm_shell.h:464: friend class mus::WmTestHelper;
Lemme know if you would prefer a WmShellTestApi class.

[commit-bot: I haz the power, 2016-10-11 20:06:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-11 20:06:48]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[sky, 2016-10-11 20:56:24]

LGTM

https://codereview.chromium.org/2408273002/diff/1/ash/common/wm_shell.h
File ash/common/wm_shell.h (right):

https://codereview.chromium.org/2408273002/diff/1/ash/common/wm_shell.h#newco...
ash/common/wm_shell.h:464: friend class mus::WmTestHelper;
On 2016/10/11 19:58:37, James Cook wrote:
> Lemme know if you would prefer a WmShellTestApi class.

I think that would be cleaner, but if you want to do it separately I'm fine with
that.

[James Cook, 2016-10-11 22:36:28]

The CQ bit was checked by jamescook@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-11 22:37:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[James Cook, 2016-10-11 22:37:46]

sky, please take another look. I added WmShellTestApi.

(FYI - This CL cannot land until we disable running mash_unittests on Linux. We
create the tray update icon on Windows and Chrome OS, but not Linux, so this
test crashes on Linux.)

[commit-bot: I haz the power, 2016-10-11 22:48:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-11 22:48:31]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[sky, 2016-10-11 23:12:37]

SLGTM

[James Cook, 2016-10-12 04:11:22]

The CQ bit was checked by jamescook@chromium.org

[James Cook, 2016-10-12 04:11:23]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org
Link to the patchset: https://codereview.chromium.org/2408273002/#ps20001
(title: "WmShellTestApi")

[commit-bot: I haz the power, 2016-10-12 04:11:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-12 04:22:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-12 04:22:46]

Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[James Cook, 2016-10-12 15:39:08]

The CQ bit was checked by jamescook@chromium.org

[commit-bot: I haz the power, 2016-10-12 15:39:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-12 15:50:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-12 15:50:43]

Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[James Cook, 2016-10-12 15:52:26]

The CQ bit was checked by jamescook@chromium.org

[commit-bot: I haz the power, 2016-10-12 15:52:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-12 16:02:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-12 16:02:02]

Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[James Cook, 2016-10-12 19:14:00]

The CQ bit was checked by jamescook@chromium.org

[commit-bot: I haz the power, 2016-10-12 19:14:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-12 19:29:17]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-12 19:32:48]

Description was changed from

==========
mash: Port TrayUpdateTest to AshTest

* Add AshTest::GetPrimarySystemTray().
* Set a TestSystemTrayDelegate in mash unittests because this test relies on
there not being an update available at test start, but SystemTrayDelegateMus
is based on DefaultSystemTrayDelegate, which simulates an update being ready.

BUG=654495
TEST=ash_unittests, mash_unittests
==========

to

==========
mash: Port TrayUpdateTest to AshTest

* Add AshTest::GetPrimarySystemTray().
* Set a TestSystemTrayDelegate in mash unittests because this test relies on
there not being an update available at test start, but SystemTrayDelegateMus
is based on DefaultSystemTrayDelegate, which simulates an update being ready.

BUG=654495
TEST=ash_unittests, mash_unittests

Committed: https://crrev.com/9d7d8eafd909e356d87b94e3fd2fc7e3d7d78aec
Cr-Commit-Position: refs/heads/master@{#424822}
==========

[commit-bot: I haz the power, 2016-10-12 19:32:48]

Patchset 2 (id:??) landed as
https://crrev.com/9d7d8eafd909e356d87b94e3fd2fc7e3d7d78aec
Cr-Commit-Position: refs/heads/master@{#424822}