Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 2411923002: mash: Convert TimeViewTest to AshTest (Closed)

Created:
4 years, 2 months ago by James Cook
Modified:
4 years, 2 months ago
Reviewers:
msw
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

mash: Convert TimeViewTest to AshTest It only has ash/common dependencies. BUG=654495 TEST=ash_unittests, mash_unittests Committed: https://crrev.com/662f55a483bd54e2566782d9b064d70cd7eb210a Cr-Commit-Position: refs/heads/master@{#424957}

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M ash/BUILD.gn View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M ash/common/BUILD.gn View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M ash/common/system/date/date_view_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 23 (14 generated)
James Cook
msw, please take a look.
4 years, 2 months ago (2016-10-11 20:53:52 UTC) #4
msw
lgtm modulo compile failure (I'll look again when fixed)
4 years, 2 months ago (2016-10-11 21:02:15 UTC) #7
James Cook
msw, the compile failures were due to a bad HEAD during the try run. Still ...
4 years, 2 months ago (2016-10-11 22:39:52 UTC) #10
msw
yeah, for sure lgtm
4 years, 2 months ago (2016-10-11 22:40:19 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2411923002/20001
4 years, 2 months ago (2016-10-12 21:39:41 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/314906)
4 years, 2 months ago (2016-10-12 21:43:31 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2411923002/40001
4 years, 2 months ago (2016-10-13 03:41:47 UTC) #20
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 2 months ago (2016-10-13 04:30:57 UTC) #21
commit-bot: I haz the power
4 years, 2 months ago (2016-10-13 04:33:03 UTC) #23
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/662f55a483bd54e2566782d9b064d70cd7eb210a
Cr-Commit-Position: refs/heads/master@{#424957}

Powered by Google App Engine
This is Rietveld 408576698