Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 2408263002: Make install and update WebAPK URLs the same (Closed)

Created:
4 years, 2 months ago by pkotwicz
Modified:
4 years, 2 months ago
Reviewers:
dominickn
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make install and update WebAPK URLs the same BUG=636552 Committed: https://crrev.com/5127d8c25b58473b850a12d3e1d44dd496153c91 Cr-Commit-Position: refs/heads/master@{#425960}

Patch Set 1 : Merge branch 'master' into webapk_installer_update #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -33 lines) Patch
M chrome/browser/android/webapk/webapk_installer.cc View 4 chunks +3 lines, -15 lines 0 comments Download
M chrome/browser/android/webapk/webapk_installer_unittest.cc View 2 chunks +1 line, -18 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
pkotwicz
Dominick, can you please take a look? This change is to accomodate a similar change ...
4 years, 2 months ago (2016-10-16 20:26:11 UTC) #7
dominickn
lgtm
4 years, 2 months ago (2016-10-18 00:17:51 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2408263002/20001
4 years, 2 months ago (2016-10-18 14:16:59 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 2 months ago (2016-10-18 14:48:12 UTC) #12
commit-bot: I haz the power
4 years, 2 months ago (2016-10-18 14:51:24 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5127d8c25b58473b850a12d3e1d44dd496153c91
Cr-Commit-Position: refs/heads/master@{#425960}

Powered by Google App Engine
This is Rietveld 408576698