Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Unified Diff: chrome/browser/android/webapk/webapk_installer_unittest.cc

Issue 2408263002: Make install and update WebAPK URLs the same (Closed)
Patch Set: Merge branch 'master' into webapk_installer_update Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/android/webapk/webapk_installer.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/android/webapk/webapk_installer_unittest.cc
diff --git a/chrome/browser/android/webapk/webapk_installer_unittest.cc b/chrome/browser/android/webapk/webapk_installer_unittest.cc
index 646d2fbc9e1c740db480f7a2264f3e3615aefb39..d0842432891440e4630a0bfa68b7e38da5fca02c 100644
--- a/chrome/browser/android/webapk/webapk_installer_unittest.cc
+++ b/chrome/browser/android/webapk/webapk_installer_unittest.cc
@@ -43,9 +43,6 @@ const char* kServerUrl = "/webapkserver/";
// that the file is not an image.
const char* kIconUrl = "/simple.html";
-// The response format type expected from the WebAPK server.
-const char* kWebApkServerUrlResponseType = "?alt=proto";
-
// URL of file to download from the WebAPK server. We use a random file in the
// test data directory.
const char* kDownloadUrl = "/simple.html";
@@ -236,25 +233,11 @@ class WebApkInstallerTest : public ::testing::Test {
std::unique_ptr<net::test_server::HttpResponse> HandleWebApkRequest(
const net::test_server::HttpRequest& request) {
- return (request.relative_url == GetServerUrlForCreateWebApk() ||
- request.relative_url == GetServerUrlForUpdateWebApk())
+ return (request.relative_url == kServerUrl)
? webapk_response_builder_.Run()
: std::unique_ptr<net::test_server::HttpResponse>();
}
- std::string GetServerUrlForCreateWebApk() const {
- std::string url(kServerUrl);
- return url.append(kWebApkServerUrlResponseType);
- }
-
- std::string GetServerUrlForUpdateWebApk() const {
- std::string url(kServerUrl);
- url.append(kDownloadedWebApkPackageName);
- url.append("/");
- url.append(kWebApkServerUrlResponseType);
- return url;
- }
-
content::TestBrowserThreadBundle thread_bundle_;
net::EmbeddedTestServer test_server_;
« no previous file with comments | « chrome/browser/android/webapk/webapk_installer.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698