Add temporary DumpWithoutCrashing to understand why the filesystem URL origin checks are failing in

Add temporary DumpWithoutCrashing to understand why the filesystem URL origin checks are failing in practice.

BUG=654479
Committed: https://crrev.com/0a66889a04ad4c87af24aeaa567184bd052227bd
Cr-Commit-Position: refs/heads/master@{#424260}

[ncarter (slow), 2016-10-10 20:52:25]

Description was changed from

==========
Add DumpWithoutCrashing.

BUG=654479
==========

to

==========
Add temporary DumpWithoutCrashing to understand why the filesystem URL origin
checks are failing in practice.

BUG=654479
==========

[ncarter (slow), 2016-10-10 20:52:33]

The CQ bit was checked by nick@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-10 20:52:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ncarter (slow), 2016-10-10 20:53:34]

nick@chromium.org changed reviewers:
+ nasko@chromium.org

[ncarter (slow), 2016-10-10 20:53:35]

nasko, please review.

I've verified that we have no test coverage for this case, other than the test
that I wrote. Assuming we see dozens of reports/day, we should be able to revert
this after a day or two.

[commit-bot: I haz the power, 2016-10-10 21:43:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-10 21:43:15]

Dry run: This issue passed the CQ dry run.

[nasko, 2016-10-10 21:45:09]

LGTM

https://codereview.chromium.org/2407983002/diff/1/content/browser/child_proce...
File content/browser/child_process_security_policy_impl.cc (right):

https://codereview.chromium.org/2407983002/diff/1/content/browser/child_proce...
content/browser/child_process_security_policy_impl.cc:806:
base::debug::DumpWithoutCrashing();
Should we capture the filesystem_url contents explicitly to ensure they are in
the dump? Or do we care mostly about the stack trace?

[ncarter (slow), 2016-10-10 22:07:48]

On 2016/10/10 21:45:09, nasko (slow) wrote:
> LGTM
> 
>
https://codereview.chromium.org/2407983002/diff/1/content/browser/child_proce...
> File content/browser/child_process_security_policy_impl.cc (right):
> 
>
https://codereview.chromium.org/2407983002/diff/1/content/browser/child_proce...
> content/browser/child_process_security_policy_impl.cc:806:
> base::debug::DumpWithoutCrashing();
> Should we capture the filesystem_url contents explicitly to ensure they are in
> the dump? Or do we care mostly about the stack trace?

I was gonna be see what was in the dump already, and iterate as needed.

I have a pretty poor win rate trying guess what would or would not be in a
minidump.

[ncarter (slow), 2016-10-10 22:08:04]

The CQ bit was checked by nick@chromium.org

[commit-bot: I haz the power, 2016-10-10 22:08:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-10 22:15:46]

Description was changed from

==========
Add temporary DumpWithoutCrashing to understand why the filesystem URL origin
checks are failing in practice.

BUG=654479
==========

to

==========
Add temporary DumpWithoutCrashing to understand why the filesystem URL origin
checks are failing in practice.

BUG=654479
==========

[commit-bot: I haz the power, 2016-10-10 22:15:47]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-10-10 22:20:48]

Description was changed from

==========
Add temporary DumpWithoutCrashing to understand why the filesystem URL origin
checks are failing in practice.

BUG=654479
==========

to

==========
Add temporary DumpWithoutCrashing to understand why the filesystem URL origin
checks are failing in practice.

BUG=654479

Committed: https://crrev.com/0a66889a04ad4c87af24aeaa567184bd052227bd
Cr-Commit-Position: refs/heads/master@{#424260}
==========

[commit-bot: I haz the power, 2016-10-10 22:20:49]

Patchset 1 (id:??) landed as
https://crrev.com/0a66889a04ad4c87af24aeaa567184bd052227bd
Cr-Commit-Position: refs/heads/master@{#424260}