Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(671)

Issue 2394673002: In ChildProcessSecurityPolicy, rename to |url| to |filesystem_url| (Closed)

Created:
4 years, 2 months ago by ncarter (slow)
Modified:
4 years, 2 months ago
Reviewers:
Charlie Reis
CC:
chromium-reviews, jam, darin-cc_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename url->filesystem_url, to clarify that these are not GURLs. BUG=644966 Committed: https://crrev.com/b3c1e27eba6c0a20f1a1a1afc605e85f3a3c55eb Cr-Commit-Position: refs/heads/master@{#423997}

Patch Set 1 #

Total comments: 2

Patch Set 2 : merge #

Patch Set 3 : Fixed botched rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -33 lines) Patch
M content/browser/child_process_security_policy_impl.h View 2 chunks +16 lines, -10 lines 0 comments Download
M content/browser/child_process_security_policy_impl.cc View 1 2 3 chunks +28 lines, -23 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 24 (17 generated)
ncarter (slow)
Charlie: please review (if it compiles)
4 years, 2 months ago (2016-10-04 23:11:38 UTC) #3
Charlie Reis
Thanks-- this should clarify that it's not a GURL. LGTM w/ nit once https://codereview.chromium.org/2387173005 lands. ...
4 years, 2 months ago (2016-10-04 23:25:58 UTC) #5
ncarter (slow)
https://codereview.chromium.org/2394673002/diff/1/content/browser/child_process_security_policy_impl.cc File content/browser/child_process_security_policy_impl.cc (right): https://codereview.chromium.org/2394673002/diff/1/content/browser/child_process_security_policy_impl.cc#newcode800 content/browser/child_process_security_policy_impl.cc:800: // page On 2016/10/04 23:25:58, Charlie Reis wrote: > ...
4 years, 2 months ago (2016-10-06 18:11:24 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2394673002/20001
4 years, 2 months ago (2016-10-06 18:11:46 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/248624)
4 years, 2 months ago (2016-10-06 18:22:46 UTC) #15
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 2 months ago (2016-10-07 22:56:59 UTC) #22
commit-bot: I haz the power
4 years, 2 months ago (2016-10-07 23:01:02 UTC) #24
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/b3c1e27eba6c0a20f1a1a1afc605e85f3a3c55eb
Cr-Commit-Position: refs/heads/master@{#423997}

Powered by Google App Engine
This is Rietveld 408576698