Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Unified Diff: third_party/WebKit/Source/platform/graphics/gpu/DrawingBufferSoftwareRenderingTest.cpp

Issue 2407753002: Fix crash from state management cleanup (Closed)
Patch Set: Fix state restore missed Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/graphics/gpu/DrawingBufferSoftwareRenderingTest.cpp
diff --git a/third_party/WebKit/Source/platform/graphics/gpu/DrawingBufferSoftwareRenderingTest.cpp b/third_party/WebKit/Source/platform/graphics/gpu/DrawingBufferSoftwareRenderingTest.cpp
index 5d2faa238737670cd444ed318fad4193a7191765..cf584e5c4be76657676685a89103f4e532c4e934 100644
--- a/third_party/WebKit/Source/platform/graphics/gpu/DrawingBufferSoftwareRenderingTest.cpp
+++ b/third_party/WebKit/Source/platform/graphics/gpu/DrawingBufferSoftwareRenderingTest.cpp
@@ -53,7 +53,7 @@ class DrawingBufferSoftwareRenderingTest : public Test {
new WebGraphicsContext3DProviderSoftwareRenderingForTests(
std::move(gl)));
m_drawingBuffer = DrawingBufferForTests::create(
- std::move(provider), initialSize, DrawingBuffer::Preserve);
+ std::move(provider), nullptr, initialSize, DrawingBuffer::Preserve);
CHECK(m_drawingBuffer);
}
@@ -69,7 +69,7 @@ TEST_F(DrawingBufferSoftwareRenderingTest, bitmapRecycling) {
IntSize initialSize(InitialWidth, InitialHeight);
IntSize alternateSize(InitialWidth, AlternateHeight);
- m_drawingBuffer->reset(initialSize);
+ m_drawingBuffer->resize(initialSize);
m_drawingBuffer->markContentsChanged();
m_drawingBuffer->PrepareTextureMailbox(
&textureMailbox, &releaseCallback1); // create a bitmap.
@@ -86,7 +86,7 @@ TEST_F(DrawingBufferSoftwareRenderingTest, bitmapRecycling) {
gpu::SyncToken(),
false /* lostResource */); // release bitmap to the recycling queue
EXPECT_EQ(1, m_drawingBuffer->recycledBitmapCount());
- m_drawingBuffer->reset(alternateSize);
+ m_drawingBuffer->resize(alternateSize);
m_drawingBuffer->markContentsChanged();
// Regression test for crbug.com/647896 - Next line must not crash
m_drawingBuffer->PrepareTextureMailbox(

Powered by Google App Engine
This is Rietveld 408576698